Skip to content

governance: Implement reduced governance fee#4241

Merged
UdjinM6 merged 5 commits intodashpay:developfrom
PastaPastaPasta:gov-hf-new-fee
Nov 1, 2021
Merged

governance: Implement reduced governance fee#4241
UdjinM6 merged 5 commits intodashpay:developfrom
PastaPastaPasta:gov-hf-new-fee

Conversation

@PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Jul 10, 2021

Inspired by https://www.dashcentral.org/p/reduce-the-proposal-fee-to-one-dash

TODO:

  • Test governance objects before and after hardfork
  • Adjust timestamps HF timing for release
  • Consider implications of a node with HF active broadcasting a governance proposal object with 1 Dash fee to a network that is segmented. IE half of network has the block that activates HF, half doesn't. Since this validation appears to only happen when the collateral transaction is included in a block, and we use that block as our reference point, the result should be deterministic

@kxcd
Copy link

kxcd commented Jul 26, 2021

We passed the governance vote https://www.dashcentral.org/p/reduce-the-proposal-fee-to-one-dash happy to help with testing and will talk to Phez about documentation updates proposal generator code seems not impacted by this change, but will test as well.

UdjinM6
UdjinM6 requested changes Jul 28, 2021
View reviewed changes
@PastaPastaPasta PastaPastaPasta requested a review from UdjinM6 July 28, 2021 15:36
UdjinM6
UdjinM6 requested changes Jul 29, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, at least CI is happy now :)

Few suggestions re timestamps.

@PastaPastaPasta
Copy link
Member Author

PastaPastaPasta commented Jul 29, 2021

Hmm, I think I would propose that we postpone the merging of this until hopefully after we implement the new enhanced hard forking.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

This pull request has conflicts, please rebase.

PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Sep 21, 2021
@fanquake @PastaPastaPasta
Merge bitcoin#16350: qt: Remove unused guard
e9b57e8 
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
@PastaPastaPasta PastaPastaPasta added this to the 18 milestone Oct 15, 2021
@PastaPastaPasta PastaPastaPasta marked this pull request as ready for review October 23, 2021 03:45
@PastaPastaPasta PastaPastaPasta changed the title [WIP] governance: Implement reduced governance fee governance: Implement reduced governance fee Oct 23, 2021
thephez
thephez reviewed Oct 25, 2021
View reviewed changes
src/chainparams.cpp Outdated

// Deployment of decreased proposal fee
consensus.vDeployments[Consensus::DEPLOYMENT_GOV_FEE].bit = 7;
consensus.vDeployments[Consensus::DEPLOYMENT_GOV_FEE].nStartTime = calculate_timestamp(2021, MONTH::DEC, 1);
Copy link
Collaborator

@thephez thephez Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, now I'm going to have to convert this to a unix timestamp so I can make some sense out of it. :trollface:
You kids with your fancy ways of tracking time 🙄

UdjinM6
UdjinM6 requested changes Oct 25, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a07ae55 feels a bit out of scope tbh, would prefer it as a separate PR

@PastaPastaPasta
Copy link
Member Author

PastaPastaPasta commented Oct 30, 2021

Dropped, please review

UdjinM6
UdjinM6 requested changes Nov 1, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

timestamps are 12h off I think

@PastaPastaPasta
Copy link
Member Author

PastaPastaPasta commented Nov 1, 2021

If only we had some compile time function to calculate timestamps for us... Hmm, maybe an idea for another PR. changes applied

UdjinM6
UdjinM6 approved these changes Nov 1, 2021
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6 UdjinM6 merged commit 2204c85 into dashpay:develop Nov 1, 2021
@PastaPastaPasta PastaPastaPasta deleted the gov-hf-new-fee branch November 1, 2021 18:02
@thephez thephez mentioned this pull request Nov 11, 2021
Merged
pravblockc pushed a commit to pravblockc/dash that referenced this pull request Nov 18, 2021
@PastaPastaPasta @UdjinM6 @pravblockc
governance: Implement reduced governance fee (dashpay#4241)
9d4f436 
* Implement hf for reduced governance fee

Signed-off-by: pasta <pasta@dashboost.org>

* update VersionBitsDeploymentInfo

* Adjust activation times for gov fee hard fork

* Use raw timestamps

* Adjust timestamps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 7, 2023
@PastaPastaPasta @UdjinM6 @gades
governance: Implement reduced governance fee (dashpay#4241)
3d09d5e 
* Implement hf for reduced governance fee

Signed-off-by: pasta <pasta@dashboost.org>

* update VersionBitsDeploymentInfo

* Adjust activation times for gov fee hard fork

* Use raw timestamps

* Adjust timestamps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit to cosanta/cosanta-core that referenced this pull request Nov 11, 2023
@fanquake @gades
Merge bitcoin#16350: qt: Remove unused guard
a213cae 
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
@PastaPastaPasta @UdjinM6 @gades
governance: Implement reduced governance fee (dashpay#4241)
5c2486e 
* Implement hf for reduced governance fee

Signed-off-by: pasta <pasta@dashboost.org>

* update VersionBitsDeploymentInfo

* Adjust activation times for gov fee hard fork

* Use raw timestamps

* Adjust timestamps

Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
gades pushed a commit to piratecash/pirate that referenced this pull request Dec 9, 2023
@fanquake @gades
Merge bitcoin#16350: qt: Remove unused guard
e815e3f 
d003110 Remove unused guard (Hennadii Stepanov)

Pull request description:

  `BITCOIN_QT_TEST` is no longer used since switching to autotools build system.

  Some historical refs:
  - dashpay#807
  - dashpay#4241

ACKs for top commit:
  practicalswift:
    utACK d003110
  promag:
    ACK d003110.
  jonasschnelli:
    Verified ACK d003110

Tree-SHA512: 1242ef7927d2dbd2e47cdb50de6ebb20e4ac427a66a37b4d4de8ca1b50581d34f818cb576fc9fdfb3e7dd7259d11812e3807da33b3357850d67548b837d5549b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thephez thephez thephez left review comments

@UdjinM6 UdjinM6 UdjinM6 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Core Dev Backlog
Status: Done

Milestone

18

Development

Successfully merging this pull request may close these issues.

4 participants

@PastaPastaPasta @kxcd @UdjinM6 @thephez