Allow unbind of metakey combos#141
Merged
dmauro merged 1 commit intodmauro:developmentfrom Mar 5, 2018
Merged
Conversation
|
@aubincleme thanks for putting together a proper PR! It was my mistake to not create a separate branch for that bugfix, I didn't realize that all my subsequent patches/debugging were being added to what I had submitted :). Glad that this is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue described in #133 and for which a patch was proposed in #137. Please note that all of the credits for fixing this issue should go to @mhuebert :) .
Unfortunately, #137 now has extra commits that are not relevant for this particular issue.