[BUG] Severe performance loss since 4.38.0 docker dekstop upgrade on M1 MacOS

[Headscracher]

Description

Since the docker upgrade to 4.38.0 ( docker compose version v2.32.4 ) on my Macbook with a M1 chip I got a huge performance loss for any docker compose command with running containers. Just running docker compose ps takes for a single service 3 seconds
❯ time docker compose ps

NAME              IMAGE          COMMAND                  SERVICE   CREATED          STATUS          PORTS
coolify-redis-1   redis:latest   "docker-entrypoint.s…"   redis     34 seconds ago   Up 30 seconds   0.0.0.0:6379->6379/tcp
docker compose ps  0.06s user 0.03s system 2% cpu 3.101 total

while with a previous version (v2.31.0-desktop.2) it's only taking 0.09 seconds

NAME              IMAGE          COMMAND                  SERVICE   CREATED         STATUS         PORTS
coolify-redis-1   redis:latest   "docker-entrypoint.s…"   redis     4 minutes ago   Up 5 seconds   0.0.0.0:6379->6379/tcp
docker compose ps  0.05s user 0.03s system 94% cpu 0.090 total

docker ps itself isn't affected by it, it's just happening with docker compose

Steps To Reproduce

• Run docker desktop version 4.38.0 on a M1 Mac
• Create a simple docker-compose.yml. Only one service is enough to reproduce:

services:
  redis:
    image: redis:latest
    pull_policy: always
    ports:
      - "${FORWARD_REDIS_PORT:-6379}:6379"
    env_file:
      - .env

• Run a docker compose command that involves those containers like docker compose ps or docker compose stop

Compose Version

Docker Compose version v2.32.4-desktop.1

Docker Environment

Client:
 Version:    27.5.1
 Context:    desktop-linux
 Debug Mode: false
 Plugins:
  ai: Ask Gordon - Docker Agent (Docker Inc.)
    Version:  v0.7.3
    Path:     /Users/tobi/.docker/cli-plugins/docker-ai
  buildx: Docker Buildx (Docker Inc.)
    Version:  v0.20.1-desktop.2
    Path:     /Users/tobi/.docker/cli-plugins/docker-buildx
  compose: Docker Compose (Docker Inc.)
    Version:  v2.32.4-desktop.1
    Path:     /Users/tobi/.docker/cli-plugins/docker-compose
  debug: Get a shell into any image or container (Docker Inc.)
    Version:  0.0.38
    Path:     /Users/tobi/.docker/cli-plugins/docker-debug
  desktop: Docker Desktop commands (Beta) (Docker Inc.)
    Version:  v0.1.4
    Path:     /Users/tobi/.docker/cli-plugins/docker-desktop
  dev: Docker Dev Environments (Docker Inc.)
    Version:  v0.1.2
    Path:     /Users/tobi/.docker/cli-plugins/docker-dev
  extension: Manages Docker extensions (Docker Inc.)
    Version:  v0.2.27
    Path:     /Users/tobi/.docker/cli-plugins/docker-extension
  feedback: Provide feedback, right in your terminal! (Docker Inc.)
    Version:  v1.0.5
    Path:     /Users/tobi/.docker/cli-plugins/docker-feedback
  init: Creates Docker-related starter files for your project (Docker Inc.)
    Version:  v1.4.0
    Path:     /Users/tobi/.docker/cli-plugins/docker-init
  sbom: View the packaged-based Software Bill Of Materials (SBOM) for an image (Anchore Inc.)
    Version:  0.6.0
    Path:     /Users/tobi/.docker/cli-plugins/docker-sbom
  scout: Docker Scout (Docker Inc.)
    Version:  v1.16.1
    Path:     /Users/tobi/.docker/cli-plugins/docker-scout

Server:
 Containers: 8
  Running: 1
  Paused: 0
  Stopped: 7
 Images: 25
 Server Version: 27.5.1
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: false
  Native Overlay Diff: true
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: cgroupfs
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local splunk syslog
 CDI spec directories:
  /etc/cdi
  /var/run/cdi
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: bcc810d6b9066471b0b6fa75f557a15a1cbf31bb
 runc version: v1.1.12-0-g51d5e946
 init version: de40ad0
 Security Options:
  seccomp
   Profile: unconfined
  cgroupns
 Kernel Version: 6.12.5-linuxkit
 Operating System: Docker Desktop
 OSType: linux
 Architecture: aarch64
 CPUs: 8
 Total Memory: 3.827GiB
 Name: docker-desktop
 ID: 10b894bc-4821-48c4-8d15-16cd1c8a18e8
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 HTTP Proxy: http.docker.internal:3128
 HTTPS Proxy: http.docker.internal:3128
 No Proxy: hubproxy.docker.internal
 Labels:
  com.docker.desktop.address=unix:///Users/tobi/Library/Containers/com.docker.docker/Data/docker-cli.sock
 Experimental: false
 Insecure Registries:
  hubproxy.docker.internal:5555
  127.0.0.0/8
 Live Restore Enabled: false

Anything else?

No response

[idsulik]

I've checked it, and the issue with the docker backend, it takes a couple of seconds to respond. it's not related to the docker compose, because with the same docker compose if you do the same action but with prev version of the docker desktop, it works fine.

vendor/github.com/docker/docker/client/container_list.go:15 - here is the place that takes the time

[idsulik]

curl -w "%{time_total}\n" --unix-socket /var/run/docker.sock http://localhost/v1.47/containers/json
3.004582

downgraded to the previous docker desktop(4.37.2 (179585)):
0.003464

[idsulik]

The reason for the delay is this PR, the user agent was changed, it used a specific user agent(more details here docker/for-mac#7575 (comment))

[idsulik]

Pushed fix here #12516, the user agent in the client.go works fine, fixed it in the main.go

[Headscracher]

Closing as it's not a docker compose issue