Skip to content

remove ValidateTagUniqueness#2478

Merged
jycor merged 3 commits into
mainfrom
james/schema-hash
Mar 20, 2026
Merged

remove ValidateTagUniqueness#2478
jycor merged 3 commits into
mainfrom
james/schema-hash

Conversation

@jycor

@jycor jycor commented Mar 19, 2026

Copy link
Copy Markdown
Contributor

companion pr: dolthub/dolt#10707

@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor
Main PR
covering_index_scan_postgres 1031.41/s 980.63/s -5.0%
index_join_postgres 151.96/s 151.08/s -0.6%
index_join_scan_postgres 189.71/s 190.41/s +0.3%
index_scan_postgres 11.61/s 11.67/s +0.5%
oltp_point_select 2401.54/s 2400.50/s -0.1%
oltp_read_only 1746.81/s 1768.50/s +1.2%
select_random_points 123.86/s 119.96/s -3.2%
select_random_ranges 779.36/s 773.40/s -0.8%
table_scan_postgres 11.32/s 11.38/s +0.5%
types_table_scan_postgres 5.14/s 5.20/s +1.1%

@github-actions

github-actions Bot commented Mar 19, 2026

Copy link
Copy Markdown
Contributor
Main PR
Total 42090 42090
Successful 17732 17782
Failures 24358 24308
Partial Successes1 5563 5573
Main PR
Successful 42.1288% 42.2476%
Failures 57.8712% 57.7524%

${\color{red}Regressions (1)}$

random

QUERY:          (SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1);
RECEIVED ERROR: expected row count 0 but received 1

${\color{lightgreen}Progressions (52)}$

rowtypes

QUERY: create temp table quadtable(f1 int, q quad);
QUERY: create temp table people (fn fullname, bd date);
QUERY: create temp table pp (f1 text);
QUERY: insert into pp values (repeat('abcdefghijkl', 100000));
QUERY: select ROW(1,2) < ROW(1,3) as true;
QUERY: select ROW(1,2) < ROW(1,NULL) as null;
QUERY: select ROW(1,2,3) < ROW(1,3,NULL) as true;
QUERY: select ROW(11,'ABC') < ROW(11,'DEF') as true;
QUERY: select ROW(12,'ABC') > ROW(11,'DEF') as true;
QUERY: select ROW(1,2,3) < ROW(1,NULL,4) as null;
QUERY: select ROW(1,2,3) <> ROW(1,NULL,4) as true;
QUERY: select ROW(1,2) = ROW(1,2::int8);
QUERY: select ROW(1,2) in (ROW(3,4), ROW(1,2));
QUERY: select ROW(1,2) in (ROW(3,4), ROW(1,2::int8));
QUERY: select thousand, tenthous from tenk1
where (thousand, tenthous) >= (997, 5000)
order by thousand, tenthous;
QUERY: create temp table test_table (a text, b text);
QUERY: insert into test_table values ('a', 'b');
QUERY: insert into test_table select 'a', null from generate_series(1,1000);
QUERY: insert into test_table values ('b', 'a');
QUERY: create index on test_table (a,b);
QUERY: set enable_sort = off;
QUERY: select a,b from test_table where (a,b) > ('a','a') order by a,b;
QUERY: reset enable_sort;
QUERY: select ROW();
QUERY: select ROW() IS NULL;
QUERY: select array[ row(1,2), row(3,4), row(5,6) ];
QUERY: select row(1,1.1) = any (array[ row(7,7.7), row(1,1.1), row(0,0.0) ]);
QUERY: select row(1,1.1) = any (array[ row(7,7.7), row(1,1.0), row(0,0.0) ]);
QUERY: create type testtype1 as (a int, b int);
QUERY: create type testtype3 as (a int, b text);
QUERY: create type testtype5 as (a int);
QUERY: create type testtype2 as (a smallint, b bool);
QUERY: CREATE TABLE price (
    id SERIAL PRIMARY KEY,
    active BOOLEAN NOT NULL,
    price NUMERIC
);
QUERY: CREATE TYPE price_input AS (
    id INTEGER,
    price NUMERIC
);
QUERY: CREATE TYPE price_key AS (
    id INTEGER
);
QUERY: insert into price values (1,false,42), (10,false,100), (11,true,17.99);
QUERY: rollback;
QUERY: create temp table compos (f1 int, f2 text);
QUERY: select cast (fullname as text) from fullname;
QUERY: select fullname::text from fullname;

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

@jycor jycor enabled auto-merge (squash) March 20, 2026 18:09

@zachmu zachmu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

KGTM

@jycor jycor merged commit 06821e8 into main Mar 20, 2026
17 checks passed
@jycor jycor deleted the james/schema-hash branch March 20, 2026 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants