Skip to content

DEALLOCATE ALL#2583

Merged
zachmu merged 1 commit into
mainfrom
zachmu/deallocate
Apr 14, 2026
Merged

DEALLOCATE ALL#2583
zachmu merged 1 commit into
mainfrom
zachmu/deallocate

Conversation

@zachmu
Copy link
Copy Markdown
Member

@zachmu zachmu commented Apr 13, 2026

Fixes #2575

@zachmu zachmu requested a review from Hydrocharged April 14, 2026 00:00
@github-actions
Copy link
Copy Markdown
Contributor

Main PR
covering_index_scan_postgres 1074.49/s 1070.59/s -0.4%
index_join_postgres 153.41/s 156.83/s +2.2%
index_join_scan_postgres 203.04/s 205.86/s +1.3%
index_scan_postgres 11.97/s 12.09/s +1.0%
oltp_point_select 2309.39/s 2309.86/s 0.0%
oltp_read_only 1815.77/s 1842.53/s +1.4%
select_random_points 127.91/s 128.48/s +0.4%
select_random_ranges 824.18/s 831.56/s +0.8%
table_scan_postgres 11.72/s 11.76/s +0.3%
types_table_scan_postgres 5.40/s 5.43/s +0.5%

@github-actions
Copy link
Copy Markdown
Contributor

Main PR
Total 42090 42090
Successful 17976 17927
Failures 24114 24163
Partial Successes1 5636 5626
Main PR
Successful 42.7085% 42.5921%
Failures 57.2915% 57.4079%

${\color{red}Regressions (49)}$

rowtypes

QUERY:          create temp table quadtable(f1 int, q quad);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          create temp table people (fn fullname, bd date);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          create temp table pp (f1 text);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          insert into pp values (repeat('abcdefghijkl', 100000));
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          select ROW(1,2) < ROW(1,3) as true;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2) < ROW(1,NULL) as null;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2,3) < ROW(1,3,NULL) as true;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(11,'ABC') < ROW(11,'DEF') as true;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(12,'ABC') > ROW(11,'DEF') as true;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2,3) < ROW(1,NULL,4) as null;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2,3) <> ROW(1,NULL,4) as true;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2) = ROW(1,2::int8);
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2) in (ROW(3,4), ROW(1,2));
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW(1,2) in (ROW(3,4), ROW(1,2::int8));
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select thousand, tenthous from tenk1
where (thousand, tenthous) >= (997, 5000)
order by thousand, tenthous;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          create temp table test_table (a text, b text);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          insert into test_table values ('a', 'b');
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          insert into test_table select 'a', null from generate_series(1,1000);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          insert into test_table values ('b', 'a');
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          create index on test_table (a,b);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          set enable_sort = off;
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          select a,b from test_table where (a,b) > ('a','a') order by a,b;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          reset enable_sort;
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          select ROW();
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select ROW() IS NULL;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select array[ row(1,2), row(3,4), row(5,6) ];
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select row(1,1.1) = any (array[ row(7,7.7), row(1,1.1), row(0,0.0) ]);
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select row(1,1.1) = any (array[ row(7,7.7), row(1,1.0), row(0,0.0) ]);
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          create type testtype2 as (a smallint, b bool);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          CREATE TABLE price (
    id SERIAL PRIMARY KEY,
    active BOOLEAN NOT NULL,
    price NUMERIC
);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          CREATE TYPE price_input AS (
    id INTEGER,
    price NUMERIC
);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          CREATE TYPE price_key AS (
    id INTEGER
);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          insert into price values (1,false,42), (10,false,100), (11,true,17.99);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          rollback;
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          create temp table compos (f1 int, f2 text);
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference
QUERY:          select cast (fullname as text) from fullname;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select fullname::text from fullname;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select cast (row('Jim', 'Beam') as text);
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          select (row('Jim', 'Beam'))::text;
RECEIVED ERROR: DoltgresHandler caught panic: runtime error: invalid memory address or nil pointer dereference (errno 1105) (sqlstate HY000)
QUERY:          insert into fullname values ('Joe', 'Blow');
RECEIVED ERROR: runtime error: invalid memory address or nil pointer dereference

${\color{lightgreen}Progressions (3)}$

prepare

QUERY: DEALLOCATE ALL;

random

QUERY: (SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1)
INTERSECT
(SELECT unique1 AS random
  FROM onek ORDER BY random() LIMIT 1);

rowtypes

QUERY: select ROW() = ROW();

Footnotes

  1. These are tests that we're marking as Successful, however they do not match the expected output in some way. This is due to small differences, such as different wording on the error messages, or the column names being incorrect while the data itself is correct.

Copy link
Copy Markdown
Collaborator

@Hydrocharged Hydrocharged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zachmu zachmu merged commit 40cca24 into main Apr 14, 2026
21 checks passed
@zachmu zachmu deleted the zachmu/deallocate branch April 14, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEALLOCATE ALL --> spurious error

2 participants