Comment containing the word "event" after property breaks the rest of the file

[michaelblyons]

Details

VS Code 1.23.0
C# for VS Code 1.14.0

Repro

public class Foo
{
    // The word "event" in the comment below breaks highlighting in the rest
    // of the file.  Adding or removing any characters in "event" such that
    // it no longer matches \bevent\b will restore highlighting.
    public string Bar { get; set; } // comment comment event comment
    public string Baz { get; set; }
}

[DustinCampbell]

Thanks for taking the time to file this issue! This is another case of #75.

I found it with properties in struct, reading this and the linked issue suggest that it breaks with event, struct, enum and class.

public struct MyPoco
{
    public ETag Tag { get; } /* note: struct ETag was previously defined ... */
}

however, it doesn't have issue with fields:

public struct MyPoco
{
    public readonly ETag Tag; /* note: struct ETag was previously defined ... */
}

@DustinCampbell, @idafi could the rule be modified to exclude the comment? The AST grammar syntax is quite new to me, I would really if someone more knowledgeable could contribute and fix this issue.

[DustinCampbell]

It may in fact be a challenge with the property pattern. I'll take a look.

Note that excluding comments from rules results in comments not being highlighted at all.

The reality is that regular expressions are a terrible way to syntax highlight a language. 😄

[DustinCampbell]

It looks like the rule that's causing this behavior is right here: https://github.com/dotnet/csharp-tmLanguage/blob/master/src/csharp.tmLanguage.yml#L492. Commenting that fixes the issue, but introduces others.

Thanks! 🎉

[DustinCampbell]

No problem. It was your comment about it being an issue for properties but not for fields that led me to the problematic rule. 😄