Fix multiplication in parameters not being highlighted correctly#111
Merged
DustinCampbell merged 1 commit intodotnet:masterfrom Apr 23, 2018
Muchiachio:TM-82/99
Merged
Fix multiplication in parameters not being highlighted correctly#111DustinCampbell merged 1 commit intodotnet:masterfrom Muchiachio:TM-82/99
DustinCampbell merged 1 commit intodotnet:masterfrom
Muchiachio:TM-82/99
Conversation
Member
|
You're right that this is probably the better judgement call. I think this will cause a lot of highlighting problems when pointer types are used in many contexts (e.g. casts, parameters, etc.), but I it's definitely better to prefer arithmetic expressions. |
DustinCampbell
added a commit
to DustinCampbell/vscode
that referenced
this pull request
May 2, 2018
* Prefer multiplication over pointer types. ([csharp-tmLanguage#111](dotnet/csharp-tmLanguage#111)) * Add support for verbatim identifiers. ([csharp-tmLanguage#112](dotnet/csharp-tmLanguage#112)) All fixes contributed by [@Muchiachio](https://github.com/Muchiachio).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Didn't want to introduce additional complexity here, so I just removed all
pointer suffixexpressions, because even with them pointer suffixes are styled askeyword.operator.arithmetic.csor are breaking syntax highlight around them. I'm also finishing verbatim identifier support #25, so it might be used as an example for future pointer support as their have similarities in character "positioning".And I think we can all agree that multiplication is used way more often than pointers in c#, so it's better to have correct syntax highlight for them. Especially knowing that currently pointers aren't styled differently.
Fixes #82, #99.