Add support for ref struct, ref readonly locals/returns#114
Merged
DustinCampbell merged 4 commits intodotnet:masterfrom May 10, 2018
Merged
Add support for ref struct, ref readonly locals/returns#114DustinCampbell merged 4 commits intodotnet:masterfrom
DustinCampbell merged 4 commits intodotnet:masterfrom
Conversation
DustinCampbell
approved these changes
May 9, 2018
Member
DustinCampbell
left a comment
DustinCampbell
left a comment
There was a problem hiding this comment.
Looks great! Just one small nit if you don't mind.
| ref-modifier: | ||
| name: storage.modifier.cs | ||
| match: \b(ref)\b | ||
| readonly-modifier: |
Member
There was a problem hiding this comment.
could you add a line break before this new rule to be consistent with the rest of the grammar?
Author
|
sure; there you go |
Member
|
Thanks! |
DustinCampbell
added a commit
to DustinCampbell/vscode
that referenced
this pull request
May 10, 2018
This update adds support for ref structs, and ref readonly locals and return types. Contributed by [@idafi](https://github.com/idafi) with dotnet/csharp-tmLanguage#114.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.