chore: update deps #5716
chore: update deps #5716
Conversation
WalkthroughDev dependency versions are bumped in Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a comprehensive update of various project dependencies, ranging from development tools and testing frameworks to linting utilities and build system components. The goal is to integrate the latest versions of these packages, ensuring the project benefits from recent bug fixes, performance improvements, and new features, thereby maintaining a robust and modern development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Deploying egg with
|
| Latest commit: |
fcfa75a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c55ec5f.egg-cci.pages.dev |
| Branch Preview URL: | https://update-deps.egg-cci.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5716 +/- ##
=======================================
Coverage 87.40% 87.40%
=======================================
Files 561 561
Lines 10932 10932
Branches 1238 1238
=======================================
Hits 9555 9555
Misses 1293 1293
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Deploying egg-v3 with
|
| Latest commit: |
fcfa75a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bbe2d828.egg-v3.pages.dev |
| Branch Preview URL: | https://update-deps.egg-v3.pages.dev |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several project dependencies, primarily through patch and minor version bumps. The changes are reflected in pnpm-lock.yaml and pnpm-workspace.yaml and include updates to packages like @types/node, vitest, lint-staged, mocha, oxlint, and prettier. These modifications appear to be standard dependency maintenance. The review did not identify any issues or inconsistencies within the updated configuration files.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pnpm-workspace.yaml (1)
53-53: Recommend running full test suite after update.After applying these dependency updates, run the full build and test pipeline to ensure compatibility:
pnpm run build– validates build integritypnpm run test– validates all tests pass (allow 180+ second timeout)pnpm run lint– validates oxlint passes with new versionAlso applies to: 66-67, 148-148, 157-157, 175-175, 184-184, 212-212
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
pnpm-workspace.yaml(6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pnpm-workspace.yaml
📄 CodeRabbit inference engine (.github/copilot-instructions.md)
Define dependencies in pnpm-workspace.yaml catalog section and reference catalog entries with 'package-name': 'catalog:' or internal workspace dependencies with 'package-name': 'workspace:*'
Files:
pnpm-workspace.yaml
🧠 Learnings (20)
📓 Common learnings
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/*/package.json,plugins/*/package.json,tools/*/package.json} : Use catalog: for external dependencies defined in pnpm-workspace.yaml
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Applies to pnpm-workspace.yaml : Define dependencies in pnpm-workspace.yaml catalog section and reference catalog entries with 'package-name': 'catalog:' or internal workspace dependencies with 'package-name': 'workspace:*'
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/*/package.json,plugins/*/package.json,tools/*/package.json} : Use workspace:* for internal package dependencies in package.json
Learnt from: CR
Repo: eggjs/egg PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-27T14:39:09.305Z
Learning: Applies to package.json : Keep local Node.js and pnpm versions aligned with the repo's `packageManager` field in configuration files
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: All packages in this monorepo require Node.js >= 22.18.0
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Build all packages first using 'pnpm run build' before making changes, then validate with lint, tests, and documentation site checks
Learnt from: CR
Repo: eggjs/egg PR: 0
File: tegg/CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:55.513Z
Learning: Applies to tegg/**/package.json : Use `workspace:*` protocol for internal tegg and egg monorepo dependencies in package.json
Learnt from: CR
Repo: eggjs/egg PR: 0
File: tegg/CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:55.513Z
Learning: Applies to tegg/**/package.json : Use `catalog:` protocol for shared external dependencies in package.json
Learnt from: CR
Repo: eggjs/egg PR: 0
File: tegg/CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:55.513Z
Learning: Applies to tegg/core/*/package.json : Include standard build scripts in package.json: typecheck, clean, and build with tsdown and tsc
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/!(egg|cookies)/test/**/*.test.ts,plugins/*/test/**/*.test.ts,tools/!(egg-bin)/test/**/*.test.ts} : All new packages MUST use Vitest for testing (exception: egg-bin and cookies packages use Mocha)
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/*/package.json,plugins/*/package.json,tools/*/package.json} : Use catalog: for external dependencies defined in pnpm-workspace.yaml
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:37:59.711Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Applies to pnpm-workspace.yaml : Define dependencies in pnpm-workspace.yaml catalog section and reference catalog entries with 'package-name': 'catalog:' or internal workspace dependencies with 'package-name': 'workspace:*'
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/*/package.json,plugins/*/package.json,tools/*/package.json} : Use workspace:* for internal package dependencies in package.json
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: All packages in this monorepo require Node.js >= 22.18.0
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:39:09.305Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-27T14:39:09.305Z
Learning: Applies to package.json : Keep local Node.js and pnpm versions aligned with the repo's `packageManager` field in configuration files
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:37:59.711Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Run 'pnpm run test' to validate changes (set timeout to 180+ seconds for all tests, 120+ seconds for coverage) and never cancel the command
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:55.513Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: tegg/CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:55.513Z
Learning: Applies to tegg/**/package.json : Use `workspace:*` protocol for internal tegg and egg monorepo dependencies in package.json
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:37:59.711Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Build all packages first using 'pnpm run build' before making changes, then validate with lint, tests, and documentation site checks
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:37:59.711Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Node.js >= 20.19.0 is required - this is a hard requirement
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/!(egg|cookies)/test/**/*.test.ts,plugins/*/test/**/*.test.ts,tools/!(egg-bin)/test/**/*.test.ts} : All new packages MUST use Vitest for testing (exception: egg-bin and cookies packages use Mocha)
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:37:59.711Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Applies to packages/**/test/**/*.test.ts : Use Vitest as the standard test runner for all packages; test files follow pattern 'test/**/*.test.ts'
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:55.513Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: tegg/CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:55.513Z
Learning: Applies to tegg/**/*.{test,spec}.{ts,tsx} : Use Vitest for testing all tegg packages with configuration from monorepo root vitest.config.ts
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:37:59.711Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-11-27T14:37:59.711Z
Learning: Applies to packages/**/test/**/*.test.ts : Use 'import { describe, it } from "vitest"' for test functions in Vitest test files
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to **/*.test.ts : Use Node.js built-in `assert` module for assertions in Vitest tests
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {packages/cookies/test/**/*.test.ts,tools/egg-bin/test/**/*.test.ts} : Use Mocha test framework for egg-bin and cookies packages
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Use oxlint with `--type-aware` flag for linting across all packages instead of ESLint
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:39:09.305Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-11-27T14:39:09.305Z
Learning: Applies to **/*.{ts,tsx,js,jsx} : Use two-space indentation, trailing commas, and semicolons enforced by Prettier and oxlint
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:37.671Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:37.671Z
Learning: Applies to {.eslintrc,.eslintrc.js,.eslintrc.json} : Remove `.eslintrc`, `.eslintrc.js`, and `.eslintrc.json` files when migrating packages to oxlint
Applied to files:
pnpm-workspace.yaml
📚 Learning: 2025-11-27T14:38:55.513Z
Learnt from: CR
Repo: eggjs/egg PR: 0
File: tegg/CLAUDE.md:0-0
Timestamp: 2025-11-27T14:38:55.513Z
Learning: Applies to tegg/core/*/package.json : Include standard build scripts in package.json: typecheck, clean, and build with tsdown and tsc
Applied to files:
pnpm-workspace.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (22)
- GitHub Check: Socket Security: Pull Request Alerts
- GitHub Check: Test (macos-latest, 22, 3/3)
- GitHub Check: Test (ubuntu-latest, 24, 3/3)
- GitHub Check: Test (ubuntu-latest, 22, 3/3)
- GitHub Check: Test (windows-latest, 24, 3/3)
- GitHub Check: Test (macos-latest, 22, 1/3)
- GitHub Check: Test (windows-latest, 24, 1/3)
- GitHub Check: Test (windows-latest, 22, 2/3)
- GitHub Check: Test (macos-latest, 24, 3/3)
- GitHub Check: Test (macos-latest, 22, 2/3)
- GitHub Check: Test (macos-latest, 24, 1/3)
- GitHub Check: Test (windows-latest, 24, 2/3)
- GitHub Check: Test (ubuntu-latest, 22, 2/3)
- GitHub Check: Test bin (windows-latest, 22, 1/3)
- GitHub Check: Test bin (ubuntu-latest, 22, 0/3)
- GitHub Check: Test bin (windows-latest, 22, 2/3)
- GitHub Check: Test bin (ubuntu-latest, 22, 2/3)
- GitHub Check: Test bin (ubuntu-latest, 22, 1/3)
- GitHub Check: Test bin (windows-latest, 22, 0/3)
- GitHub Check: typecheck
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Cloudflare Pages: egg-v3
🔇 Additional comments (2)
pnpm-workspace.yaml (2)
53-53: Dependency version updates look good overall.The majority of changes are patch version bumps for development dependencies, which are generally safe. However, the oxlint and prettier updates involve larger version increments that could impact the build and code formatting.
Also applies to: 66-67, 148-148, 157-157, 175-175, 184-184, 212-212
174-174: Dependency is correctly placed in catalog; breaking changes between 1.25.0 and 1.31.0 are minimal.The version jump spans 6 minor versions but includes only one documented breaking change: v1.30.0's addition of
TSGlobalDeclarationtype to the AST, which does not introduce new linting rules that would affect existing code. The update is safe to proceed.
| picocolors: ^1.1.1 | ||
| pluralize: ^8.0.0 | ||
| prettier: ^3.6.2 | ||
| prettier: ^3.7.4 |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
prettier 3.7.4 changelog breaking changes formatting 3.6.2
💡 Result:
Summary of notable formatting / breaking changes from Prettier 3.6.2 → 3.7.4
-
Prettier 3.7.x includes multiple formatting improvements and some breaking/plugin-surface changes documented in the 3.7 release notes (examples: improved consistency between class vs interface printing in TypeScript, new line-wrapping/printing behaviors for imports and strings). See Prettier 3.7.0 release notes. [1]
-
Many of the larger breaking-area changes (ESM migration, plugin API async/embed signature, CJK/Latin spacing in Markdown, default trailingComma change) were introduced earlier in the v3 series and are documented in Prettier’s changelogs/blog posts — they remain relevant when upgrading across minor 3.x releases. If you rely on plugins or custom printers, check the plugin API notes. [1][2]
-
For the exact, line-by-line changelog between 3.6.2 and 3.7.4 (all formatting fixes, bug fixes and any tiny breaking fixes), consult the project changelog / release diffs (CHANGELOG.md and the 3.7.4 vs 3.7.3 source diff). Those show every change included in 3.7.4. [2][3]
References
- Prettier 3.7.0 release notes (formatting highlights & breaking notes). [1]
- Prettier changelog / release listings (versions including 3.6.2 → 3.7.4). [2]
- Source/diff report for 3.7.3 → 3.7.4 (shows precise code changes included). [3]
Would you like me to fetch and paste the specific CHANGELOG.md entries that list only the breaking changes between 3.6.2 and 3.7.4?
🏁 Script executed:
# Check prettier release information for versions 3.6.2 through 3.7.4
curl -s https://api.github.com/repos/prettier/prettier/releases | jq '.[] | select(.tag_name | test("3\\.[67]\\.")) | {tag_name: .tag_name, published_at: .published_at, prerelease: .prerelease}' | head -100Repository: eggjs/egg
Length of output: 780
Verify prettier update (3.6.2 → 3.7.4) for formatting consistency.
The prettier 3.7.x release series introduces formatting changes including improved TypeScript class/interface printing consistency and new line-wrapping behaviors for imports and strings. Before merging this update, verify that the formatting output changes are compatible with your existing code and CI/CD pipelines, particularly if TypeScript or custom import formatting conventions are in use.
There was a problem hiding this comment.
Pull request overview
This PR updates development dependencies across the monorepo. The changes include updates to testing tools, type definitions, linters, and formatters.
- Updates 10 packages in the pnpm workspace catalog
- Most updates are patch-level (bug fixes), with two minor updates (oxlint and prettier)
- All lockfile changes are consistent with the catalog updates
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates 10 dev dependencies in the catalog: @types/node, vitest ecosystem packages, lint-staged, mocha, oxlint, oxlint-tsgolint, prettier, and rimraf |
| pnpm-lock.yaml | Corresponding lockfile updates reflecting the catalog changes, including transitive dependencies (rolldown bindings, glob, minimatch, path-scurry, lru-cache) and version resolution updates across all workspace packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
| '@types/mocha': ^10.0.10 | ||
| '@types/mustache': ^4.2.5 | ||
| '@types/node': ^24.10.0 | ||
| '@types/node': ^24.10.1 |
There was a problem hiding this comment.
The commit message does not follow the required Angular Commit Message Format.
The message should include:
- A type (like
chore) - An optional scope in parentheses
- A colon and space
- A subject starting with lowercase
Example: chore(deps): update dependencies to latest versions
The current message "chore: update deps" is too vague. It should be more descriptive, such as:
chore(deps): update vitest, oxlint, prettier and other dev dependencieschore(deps): update @types/node and dev tooling dependencies
1 participant
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.