Conversation
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 135 files out of 242 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying egg-v3 with
|
| Latest commit: |
c91cd5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9eb62199.egg-v3.pages.dev |
| Branch Preview URL: | https://oxfmt-0-19.egg-v3.pages.dev |
Summary of ChangesHello @fengmk2, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates oxfmt to version 0.19.0 and applies the new formatting across the codebase. The changes primarily consist of updating the dependency in pnpm-workspace.yaml, removing Prettier configuration files, and applying formatting changes to various YAML, JSON, and Markdown files. The key reordering in package.json files and quote style changes in pnpm-workspace.yaml are consistent with the formatter update. The changes are clean, correct, and align with the goal of the pull request.
Deploying egg with
|
| Latest commit: |
c91cd5e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d2311ffb.egg-cci.pages.dev |
| Branch Preview URL: | https://oxfmt-0-19.egg-cci.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## next #5737 +/- ##
=======================================
Coverage 87.61% 87.62%
=======================================
Files 569 569
Lines 10941 10941
Branches 1238 1238
=======================================
+ Hits 9586 9587 +1
+ Misses 1271 1270 -1
Partials 84 84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the oxfmt tool from version 0.15.0 to 0.19.0 and applies the new formatter's output across the codebase. The changes are primarily cosmetic, consisting of automatic reformatting of JSON and other files according to oxfmt 0.19's formatting rules.
Key changes:
- Update oxfmt dependency from ^0.15.0 to ^0.19.0 in the pnpm workspace catalog
- Remove prettier dependency and configuration files (moving to oxfmt for formatting)
- Reformat all package.json files to match oxfmt 0.19's standard field ordering
- Minor formatting adjustments to markdown tables and TypeScript configuration
Reviewed changes
Copilot reviewed 239 out of 243 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Updates oxfmt from 0.15.0 to 0.19.0; removes prettier dependency |
| All package.json files | Reformatted with consistent field ordering: metadata fields first (name, version, description, keywords, homepage, bugs, license, author, repository), then files/type/main/exports, publishConfig, scripts, dependencies, devDependencies, peerDependencies, engines, and plugin-specific fields last |
| tools/create-egg/test/cli.test.ts | Reformatted test code indentation |
| tegg/plugin/tegg/test/*.test.ts | Removed extra blank lines |
| site/tsconfig.json | Compressed exclude array to single line |
| site/package.json | Removed prettier script and devDependency |
| site/.prettierrc, site/.prettierignore | Deleted prettier configuration files |
| site/docs/advanced/loader.md, site/docs/zh-CN/advanced/loader.md | Adjusted table column alignment |
| .prettierignore | Removed root prettier ignore file |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
1 participant
No description provided.