Skip to content

Added dockerfiles form trzeci/emscripten-docker#368

Merged
sbc100 merged 11 commits into
emscripten-core:masterfrom
trzecieu:ppp/dockerfiles
Oct 11, 2019
Merged

Added dockerfiles form trzeci/emscripten-docker#368
sbc100 merged 11 commits into
emscripten-core:masterfrom
trzecieu:ppp/dockerfiles

Conversation

@trzecieu

@trzecieu trzecieu commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

As a continuation from: emscripten-core/emscripten#8742

This PR provides adopted Dockerfile from https://github.com/trzecieu/emscripten-docker/blob/master/docker/trzeci/emscripten-fastcomp/Dockerfile which supports builds:

  • fastcomp
  • upstream

Features:

  • An image can be build with fastcomp and upstream version of Emscripten SDK
  • It applies some extra size optimizations (that might be removed in sake of clarity / stability)
  • It creates conventional 1000:1000 user emscripten
  • It creates extra entrypoint that mitigates running as non-root user (Some context: https://trzeci.eu/fixing-permission-of-files-created-from-docker/)
  • It has simple-stupid tests performed during building

I understand that some of used solutions might not meet expectations, hence I'm open for suggestions how to improve it.

CC: @kripken @sbc100

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have lots of small nits but generally I think this I good thing and we should include it here.

If you'd like to address some of these issues after the initial commit I'd be OK with that too.

Comment thread docker/README.md
Comment thread docker/Dockerfile Outdated
Comment thread docker/Dockerfile Outdated
Comment thread docker/entrypoint Outdated
Comment thread docker/entrypoint Outdated
Comment thread docker/entrypoint Outdated
Comment thread docker/Dockerfile
Comment thread docker/test_dockerimage.sh
Comment thread docker/Dockerfile

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me now. @kripken how about you?

Can we add this under https://hub.docker.com/u/emscripten? Perhaps as "emsdk"?

Comment thread docker/README.md Outdated
Comment thread docker/Dockerfile Outdated
@kripken

kripken commented Oct 9, 2019

Copy link
Copy Markdown
Member

No comments from me, looks reasonable, thanks!

Would it be possible to test this? (as in, test that building this Docker image leads to a working environment?)

Sounds good to add to docker hub. Let me know your usernames there and I'll add you.

@sbc100

sbc100 commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator

I'm sbc100 on docker hub

@trzecieu

trzecieu commented Oct 9, 2019

Copy link
Copy Markdown
Collaborator Author

I'm trzeci on docker hub

@kripken

kripken commented Oct 11, 2019

Copy link
Copy Markdown
Member

Ok, added you two and a team and a repo, hopefully I've done it all correctly, let me know!

@sbc100 sbc100 merged commit c564225 into emscripten-core:master Oct 11, 2019
@trzecieu trzecieu deleted the ppp/dockerfiles branch October 11, 2019 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants