This repository was archived by the owner on Apr 4, 2024. It is now read-only.
fix: Update the JSON-RPC to correct the return information.#1006
Merged
fedekunze merged 6 commits intoevmos:mainfrom Mar 21, 2022
WilliamXieCrypto:web3-sha3
Merged
fix: Update the JSON-RPC to correct the return information.#1006fedekunze merged 6 commits intoevmos:mainfrom WilliamXieCrypto:web3-sha3
fedekunze merged 6 commits intoevmos:mainfrom
WilliamXieCrypto:web3-sha3
Conversation
fedekunze
reviewed
Mar 21, 2022
Contributor
fedekunze
left a comment
There was a problem hiding this comment.
Thanks! minor comment to move the tests to the new package
fedekunze
reviewed
Mar 21, 2022
fedekunze
approved these changes
Mar 21, 2022
yihuang
pushed a commit
to yihuang/ethermint
that referenced
this pull request
Mar 22, 2022
* fix: Update the JSON-RPC to correct the return information. * Update CHANGELOG.md * update: move the tests to integration_test.go * refactor the tests and use table tests instead Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
yihuang
pushed a commit
to yihuang/ethermint
that referenced
this pull request
Mar 24, 2022
* fix: Update the JSON-RPC to correct the return information. * Update CHANGELOG.md * update: move the tests to integration_test.go * refactor the tests and use table tests instead Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #632
Solution:
Before the fix, the "web3_sha3" JSON_RPC endpoint will overwrite the "0x" as "" by using "hexutil.Bytes" as the input parameters, then return same result. After the fix, using "string" as the input parameters will avoid the overwrite and return correct response.
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)