This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Fix duplicate registration of feemarket GenesisState and Params#1023
Merged
fedekunze merged 3 commits intoevmos:mainfrom Apr 5, 2022
Merged
Fix duplicate registration of feemarket GenesisState and Params#1023fedekunze merged 3 commits intoevmos:mainfrom
fedekunze merged 3 commits intoevmos:mainfrom
Conversation
with existing types
fedekunze
approved these changes
Apr 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #1023 +/- ##
==========================================
+ Coverage 59.16% 59.32% +0.16%
==========================================
Files 80 80
Lines 6577 6577
==========================================
+ Hits 3891 3902 +11
+ Misses 2467 2456 -11
Partials 219 219
|
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v0.12.2 introduced legacy types which attempt to register on init, conflicting with the existing types.
This also results in the grpc server showing an incorrect description of the Params type.
The proto registration isn't needed for migrations, so we should be fine in just removing the init calls in the legacy types.
This PR fixes the warnings on init, and results in the correct registration for the feemarket Params.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)