This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Fix TxIndex wrongly when trace first Tx of a block (backport #1187)#1195
Merged
fedekunze merged 2 commits intorelease/v0.17.xfrom Jul 20, 2022
Merged
Fix TxIndex wrongly when trace first Tx of a block (backport #1187)#1195fedekunze merged 2 commits intorelease/v0.17.xfrom
fedekunze merged 2 commits intorelease/v0.17.xfrom
Conversation
…1187) * Fix TxIndex wrongly when trace first Tx of a block If `Predecessors` is empty, `txConfig.TxIndex` originally = 0 and when it reachs line 401 `txConfig.TxIndex++`, it will becomes 1. It should be 0 * apply suggestion and add change-log * fix comment Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit cd41c48) # Conflicts: # CHANGELOG.md
Codecov Report
@@ Coverage Diff @@
## release/v0.17.x #1195 +/- ##
===================================================
+ Coverage 61.80% 61.81% +0.01%
===================================================
Files 90 90
Lines 7320 7322 +2
===================================================
+ Hits 4524 4526 +2
Misses 2573 2573
Partials 223 223
|
hoanguyenkh
pushed a commit
to AstraProtocol/ethermint
that referenced
this pull request
Jul 27, 2022
…ackport evmos#1187) (evmos#1195) * fix(evm): `TxIndex` is wrong when trace is the first tx of a block (evmos#1187) * Fix TxIndex wrongly when trace first Tx of a block If `Predecessors` is empty, `txConfig.TxIndex` originally = 0 and when it reachs line 401 `txConfig.TxIndex++`, it will becomes 1. It should be 0 * apply suggestion and add change-log * fix comment Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com> (cherry picked from commit cd41c48) # Conflicts: # CHANGELOG.md * fix RPC Co-authored-by: Victor Pham <me@victortrusty.dev> Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1187 done by Mergify.
Cherry-pick of cd41c48 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com