This repository was archived by the owner on Apr 4, 2024. It is now read-only.
eth_sendTransaction returns internal trace on missing param#1284
Merged
eth_sendTransaction returns internal trace on missing param#1284
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1284 +/- ##
=======================================
Coverage 52.13% 52.13%
=======================================
Files 105 105
Lines 9547 9547
=======================================
Hits 4977 4977
Misses 4302 4302
Partials 268 268
|
adisaran64
requested review from
danburck,
facs95 and
fedekunze
as code owners
facs95
suggested changes
Aug 20, 2022
Contributor
facs95
left a comment
facs95
left a comment
There was a problem hiding this comment.
Thanks @adisaran64 ! This looks great. Please just remove those two lines and this should be ready to merge 👌
fedekunze
approved these changes
Aug 24, 2022
Contributor
fedekunze
left a comment
fedekunze
left a comment
There was a problem hiding this comment.
utACK. Can you add a bug-fix changelog entry?
facs95
approved these changes
Aug 25, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1275
Description
changes the
eth_sendTransactionrequest to provide a properly formatted error (instead of an internal stack trace) when missing input params (thefromfield)For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)