This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Closed
Conversation
fedekunze
suggested changes
Sep 7, 2022
Contributor
fedekunze
left a comment
There was a problem hiding this comment.
Minor comments, can you also add tests?
Contributor
Author
do you mean websocket tests? |
fedekunze
approved these changes
Sep 13, 2022
Contributor
fedekunze
left a comment
There was a problem hiding this comment.
ACK, would be great to add websocket tests
Contributor
|
@baabeetaa can you update the PR? |
adisaran64
approved these changes
Sep 14, 2022
Contributor
adisaran64
left a comment
There was a problem hiding this comment.
@baabeetaa will add tests with this ticket, can update and merge this PR when possible
11 tasks
Contributor
Author
|
i'll close this and update changes to #1342 with tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Batch Request is in spec of jsonrpc https://www.jsonrpc.org/specification#batch
This PR is a fix to make Batch Request working for websocket.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)