Skip to content
This repository was archived by the owner on Apr 4, 2024. It is now read-only.

test: Ethereum JSONRPC Websocket#1342

Merged
fedekunze merged 10 commits intoevmos:mainfrom
notional-labs:eth-jsonrpc-ws-test
Sep 19, 2022
Merged

test: Ethereum JSONRPC Websocket#1342
fedekunze merged 10 commits intoevmos:mainfrom
notional-labs:eth-jsonrpc-ws-test

Conversation

@baabeetaa
Copy link
Contributor

Relate: #1241 and #1326

Description

Add Eth JsonRpc Websocket test


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@baabeetaa baabeetaa marked this pull request as ready for review September 16, 2022 05:16
@baabeetaa baabeetaa requested a review from a team as a code owner September 16, 2022 05:16
@baabeetaa baabeetaa requested review from austinchandra and hanchon and removed request for a team September 16, 2022 05:16
@fedekunze fedekunze added this to the v0.20.x milestone Sep 16, 2022
Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you remove or finish the batch tests?

@baabeetaa baabeetaa mentioned this pull request Sep 16, 2022
11 tasks
@fedekunze fedekunze enabled auto-merge (squash) September 19, 2022 10:30
@fedekunze fedekunze merged commit 26c341d into evmos:main Sep 19, 2022
@danburck danburck mentioned this pull request Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants