This repository was archived by the owner on Apr 4, 2024. It is now read-only.
refactor: optimize AnteHandler gas consumption#1388
Merged
Conversation
fedekunze
reviewed
Oct 19, 2022
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1388 +/- ##
==========================================
+ Coverage 55.88% 56.00% +0.12%
==========================================
Files 108 108
Lines 10021 10049 +28
==========================================
+ Hits 5600 5628 +28
Misses 4140 4140
Partials 281 281
|
danburck
suggested changes
Oct 19, 2022
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
danburck
suggested changes
Oct 19, 2022
danburck
approved these changes
Oct 19, 2022
Contributor
There was a problem hiding this comment.
nice @Vvaradinov, I reviewed the changes and left a nit comment. Feel free to merge
danburck
reviewed
Oct 19, 2022
facs95
reviewed
Oct 19, 2022
Contributor
facs95
left a comment
There was a problem hiding this comment.
The reason why we were calling the params as a set in the places I pointed out was not to make the query several time per property and per message. I liked the idea of making the code cleaner but maybe we can find a way in which is clear but keeps same - or better performance
11 tasks
13 tasks
yihuang
pushed a commit
to crypto-org-chain/ethermint
that referenced
this pull request
Nov 3, 2022
This reverts commit 83e509b.
13 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to optimize gas consumption by reordering AnteHandlers by executing stateless ones first followed by stateful ones. Additionally it provides specific getters for each individual parameter in the keeper and only calls ones needed by the particular AnteHandler.
Closes: ENG-905 ENG-444
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)