This repository was archived by the owner on Apr 4, 2024. It is now read-only.
chore(evm, feemarket) - Migrate Event emitting to TypedEvent#1544
Merged
chore(evm, feemarket) - Migrate Event emitting to TypedEvent#1544
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1544 +/- ##
==========================================
- Coverage 68.52% 68.40% -0.12%
==========================================
Files 106 106
Lines 10077 10077
==========================================
- Hits 6905 6893 -12
- Misses 2775 2783 +8
- Partials 397 401 +4
|
GAtom22
approved these changes
Dec 12, 2022
Contributor
GAtom22
left a comment
There was a problem hiding this comment.
Great work @Vvaradinov! LGTM!
…com/evmos/ethermint into Vvaradinov/evm-migrate-typed-events
Contributor
MalteHerrmann
left a comment
There was a problem hiding this comment.
basically LGTM, left some minor nit-picking on some comments but that's personal preference really.
@Vvaradinov there are some failing tests though, which seem to reference some of the affected events (e.g. block bloom event is not found in this run) - can you either verify that this is not caused by the changes here or adjust the tests accordingly?
Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com>
mmsqe
added a commit
to mmsqe/ethermint
that referenced
this pull request
Jan 10, 2023
…vmos#1544)" This reverts commit 8886ce3.
11 tasks
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrate the usage of now deprecated
EmitEventtoEmitTypedEvent. Newevents.protois created describing each event type theevmmodule emits. Marked with aTODOa place where I am unsure how to proceed.Closes: ENG-1173
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)