This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Problem: repeated tx sender recovery is wastful#1717
Merged
facs95 merged 7 commits intoevmos:mainfrom Mar 24, 2023
Merged
Conversation
Solution: - only do once in ante handler, reuse the result * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * Update x/evm/types/msg.go Co-authored-by: mmsqe <[email protected]> Signed-off-by: yihuang <[email protected]> * return value * fix unit test --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: mmsqe <[email protected]>
yihuang
commented
Mar 16, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1717 +/- ##
==========================================
- Coverage 68.15% 67.94% -0.22%
==========================================
Files 112 112
Lines 10175 10209 +34
==========================================
+ Hits 6935 6936 +1
- Misses 2832 2865 +33
Partials 408 408
|
yihuang
commented
Mar 16, 2023
facs95
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solution:
In our erc20 transfer benchmark, it improve performance by 40+%
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)