This repository was archived by the owner on Apr 4, 2024. It is now read-only.
Migrate updated EIP-712 algorithm from Evmos#1746
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| domain := apitypes.TypedDataDomain{ | ||
| Name: "Cosmos Web3", | ||
| Version: "1.0.0", | ||
| ChainId: math.NewHexOrDecimal256(int64(chainID)), |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| domain := apitypes.TypedDataDomain{ | ||
| Name: "Cosmos Web3", | ||
| Version: "1.0.0", | ||
| ChainId: math.NewHexOrDecimal256(int64(chainID)), // #nosec G701 |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion
| return | ||
| } | ||
|
|
||
| *err = fmt.Errorf("%v", r) |
Check warning
Code scanning / gosec
Returned error is not propagated up the stack.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
+ Coverage 68.05% 68.89% +0.84%
==========================================
Files 113 117 +4
Lines 10263 10681 +418
==========================================
+ Hits 6984 7359 +375
- Misses 2869 2900 +31
- Partials 410 422 +12
|
| "encoding/json" | ||
| "fmt" | ||
| "math/big" | ||
| "reflect" // #nosec G702 for sensitive import |
Check notice
Code scanning / CodeQL
Sensitive package import
Comment on lines
+249
to
+252
| for k := range jsonMap { | ||
| keys[i] = k | ||
| i++ | ||
| } |
Check warning
Code scanning / CodeQL
Iteration over map
austinchandra
requested review from
MalteHerrmann and
facs95
and removed request for
a team
facs95
reviewed
Apr 11, 2023
Contributor
facs95
left a comment
facs95
left a comment
There was a problem hiding this comment.
Integration tests are failing
| domain := apitypes.TypedDataDomain{ | ||
| Name: "Cosmos Web3", | ||
| Version: "1.0.0", | ||
| ChainId: math.NewHexOrDecimal256(int64(chainID)), // #nosec G701 |
facs95
suggested changes
Apr 11, 2023
facs95
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
Migrate from evmos/evmos#1390.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)