Skip to content

Fix building on AIX 5.1#2281

Merged
Cyan4973 merged 1 commit into
facebook:devfrom
likema:fix-aix-51
Oct 13, 2020
Merged

Fix building on AIX 5.1#2281
Cyan4973 merged 1 commit into
facebook:devfrom
likema:fix-aix-51

Conversation

@likema

@likema likema commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

When building zstd by GCC 4.5.4 on AIX 5.1 , GCC could not found stdint.h

@facebook-github-bot

Copy link
Copy Markdown

Hi @likema!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot

Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Cyan4973

Cyan4973 commented Aug 25, 2020

Copy link
Copy Markdown
Contributor

I'm fine with the proposed update,
however, it happens there is also an ongoing patch
which changes the way zstd includes C standard libraries and defines internal types,
and it will conflict with this PR.
cc @terrelln

@Cyan4973

Cyan4973 commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

With mem.h now updated,
could you please rebase your PR onto latest dev branch ?
Once conflict is cleared, I believe it's good to go.

@likema

likema commented Oct 9, 2020

Copy link
Copy Markdown
Contributor Author

I have rebased it onto dev.

But I find that

  • contrib/pzstd/test/RoundTrip.h
  • contrib/pzstd/utils/FileSystem.h
  • contrib/pzstd/Options.h
  • contrib/pzstd/SkippableFrame.h
  • contrib/pzstd/Pzstd.h
  • contrib/single_file_libs/examples/roundtrip.c
  • contrib/single_file_libs/examples/simple.c
  • doc/educational_decoder/zstd_decompress.c

includes cstdint

Should I fix them?

@Cyan4973

Cyan4973 commented Oct 9, 2020

Copy link
Copy Markdown
Contributor

Nope, these are different programs, just hosted in the same repository.
The current scope of this PR looks good to me.

@Cyan4973 Cyan4973 merged commit 1283935 into facebook:dev Oct 13, 2020
@likema likema deleted the fix-aix-51 branch January 13, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants