fix(api): Accept null values for optional fields in /api/v1/statuses endpoin #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThisIsMissEm
reviewed
Aug 9, 2025
ThisIsMissEm
reviewed
Aug 9, 2025
Contributor
ThisIsMissEm
left a comment
ThisIsMissEm
left a comment
There was a problem hiding this comment.
This looks okay to me, but we should increase test coverage. I also want to pull this change locally and check a few things.
dahlia
approved these changes
Aug 10, 2025
Contributor
|
@dahlia I would like to see those tests merged, but I can also do it as a follow up? |
ThisIsMissEm
approved these changes
Aug 10, 2025
dahlia
added a commit
that referenced
this pull request
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #177
Updated the schemas to explicitly accept null values using .nullable() for all optional fields:
Updated the formatPostContent function to accept null values