Defines the d.ts multi-factor related comments for reference generation. #766

bojeil-google · 2020-01-17T09:09:44Z

Adds missing multi-factor related claims to the DecodedIdToken interface.

Adds missing multi-factor related claims to the `DecodedIdToken` interface.

hiranya911

LGTM with a nit.

hiranya911 · 2020-01-17T19:34:36Z

src/index.d.ts

+  interface MultiFactorInfo {
+
+    /**
+     * The unique identifier of the enrolled second factor.


Nit: This is the user's unique ID from the 2nd factor right? Perhaps make that a bit clear.

kevinthecheung · 2020-01-21T21:35:48Z

src/index.d.ts

+  interface MultiFactorInfo {
+
+    /**
+     * The user's unique ID of the enrolled second factor.


The ID of the enrolled second factor. This ID is unique to the user.

kevinthecheung · 2020-01-21T21:37:06Z

src/index.d.ts

+    uid: string;
+
+    /**
+     * The optional display name for an enrolled second factor.


The optional display name of the enrolled second factor.

kevinthecheung · 2020-01-21T21:39:09Z

src/index.d.ts

+    enrollmentTime?: string;
+
+    /**
+     * The second factor type identifier. For SMS second factor, this is `"phone"`.


The type identifier of the second factor. For SMS second factors, this is phone.

kevinthecheung · 2020-01-21T21:40:22Z

src/index.d.ts

    tenantId?: string | null;

+    /**
+     * The multi-factor related properties for the current user if available.


kevinthecheung · 2020-01-21T21:41:44Z

src/index.d.ts

-      }>;
+
+      /**
+       * List of enrolled second factors on the current user record.


List of second factors enrolled with the current user.

kevinthecheung · 2020-01-21T21:57:35Z

src/index.d.ts

-      }> | null;
+
+      /**
+       * The user's updated list of enrolled second factors. The provided list will always


The updated list of enrolled second factors. The provided list overwrites the user's existing list of second factors. When null is passed, all of the user's existing second factors are removed.

kevinthecheung · 2020-01-21T21:58:27Z

src/index.d.ts

      sign_in_provider: string;

+      /**
+       * This is the type identifier or `factorId` of the second factor, provided the


The type identifier..

kevinthecheung · 2020-01-21T21:58:55Z

src/index.d.ts

+      sign_in_second_factor?: string;
+
+      /**
+       * This is the `uid` of the second factor used to sign in, provided the


The uid of..

bojeil-google added 2 commits January 17, 2020 01:06

Defines the d.ts multi-factor related comments for reference generation.

663a948

Adds missing multi-factor related claims to the `DecodedIdToken` interface.

Added new lines to newly defined types comments.

f09497c

bojeil-google requested review from egilmorez and hiranya911 January 17, 2020 18:58

bojeil-google assigned egilmorez and hiranya911 Jan 17, 2020

hiranya911 approved these changes Jan 17, 2020

View reviewed changes

hiranya911 removed their assignment Jan 17, 2020

Address review comments.

bbaf1a8

kevinthecheung requested changes Jan 21, 2020

View reviewed changes

Addresses additional review comments.

d2ece27

bojeil-google assigned kevinthecheung and unassigned egilmorez Jan 22, 2020

kevinthecheung approved these changes Jan 22, 2020

View reviewed changes

bojeil-google merged commit f7b445d into auth-mfa Jan 22, 2020

bojeil-google deleted the auth-mfa-temp branch March 7, 2020 02:27

Defines the d.ts multi-factor related comments for reference generation. #766

Defines the d.ts multi-factor related comments for reference generation. #766

Uh oh!

Conversation

bojeil-google commented Jan 17, 2020

Uh oh!

hiranya911 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants