Optimized GetHostScriptExecutionResults MySQL query for for large numbers of script results. (#32595)#33305
Merged
getvictor merged 2 commits intoSep 22, 2025
Conversation
…bers of script results. (#32595) Fixes #32295 The issue was identified/fixed using this performance test: https://gist.github.com/getvictor/b289b7b14981fb7bf77e57c80af117d1 With the fix: - 100 records: 2.6ms (similar) - 1,000 records: ~7ms (32x faster) - 5,000 records: ~10ms (530x faster) - 10,000 records: 13ms (1,430x faster) - 20,000 records: ~25ms (2,960x faster) - 40,000 records: 50ms (6,000x faster) # Checklist for submitter - [x] Changes file added for user-visible changes in `changes/`, `orbit/changes/` or `ee/fleetd-chrome/changes`. See [Changes files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files) for more information. ## Testing - [x] QA'd all new/changed functionality manually <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Script details now surface the most relevant “latest” status per script, prioritizing upcoming executions when present. - Performance Improvements - Significantly faster loading of host script results and script details, especially at large scale. - Improved responsiveness when filtering/sorting script results. - Documentation - Added changelog entry describing the optimization to script results handling. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> (cherry picked from commit 73b629e)
getvictor
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
getvictor
had a problem deploying
to
Docker Hub
GitHub Actions
Failure
getvictor
changed the title
jahzielv
approved these changes
Sep 22, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rc-patch-fleet-v4.73.2 #33305 +/- ##
=========================================================
Coverage ? 63.22%
=========================================================
Files ? 1292
Lines ? 174390
Branches ? 0
=========================================================
Hits ? 110257
Misses ? 54588
Partials ? 9545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #32295
Cherry pick + schema update