Skip to content

Renumber 4.73.2 migrations (#33376) -> 4.73.2#33378

Merged
JordanMontgomery merged 1 commit into
rc-patch-fleet-v4.73.2from
JM-fix-4.73.2-migrations-in-4.73.2
Sep 23, 2025
Merged

Renumber 4.73.2 migrations (#33376) -> 4.73.2#33378
JordanMontgomery merged 1 commit into
rc-patch-fleet-v4.73.2from
JM-fix-4.73.2-migrations-in-4.73.2

Conversation

@JordanMontgomery
Copy link
Copy Markdown
Member

Related issue: None but cf
https://fleetdm.slack.com/archives/C019WG4GH0A/p1758654375623919

No changes file

Renumbering two migrations so they can be released as part of 4.73.2

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes
    files
    for more information.

  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)

  • If paths of existing endpoints are modified without backwards compatibility, checked the frontend/CLI for any necessary changes

  • Added/updated automated tests

  • Where appropriate, automated tests simulate multiple hosts and test for host
    isolation
    (updates to one hosts's records do not affect another)

  • QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

  • Confirmed that the fix is not expected to adversely impact load test results

  • Alerted the release DRI if additional load testing is needed

  • Checked table schema to confirm autoupdate

  • Checked schema for all modified table for columns that will auto-update timestamps during migration.

  • Confirmed that updating the timestamps is acceptable, and will not cause unwanted side effects.

  • Ensured the correct collation is explicitly set for character columns (COLLATE utf8mb4_unicode_ci).

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** None but cf
https://fleetdm.slack.com/archives/C019WG4GH0A/p1758654375623919

No changes file

Renumbering two migrations so they can be released as part of 4.73.2

If some of the following don't apply, delete the relevant line.

- [x] Changes file added for user-visible changes in `changes/`,
`orbit/changes/` or `ee/fleetd-chrome/changes`.
See [Changes
files](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/guides/committing-changes.md#changes-files)
for more information.

- [x] Input data is properly validated, `SELECT *` is avoided, SQL
injection is prevented (using placeholders for values in statements)
- [x] If paths of existing endpoints are modified without backwards
compatibility, checked the frontend/CLI for any necessary changes

- [x] Added/updated automated tests
- [x] Where appropriate, [automated tests simulate multiple hosts and
test for host
isolation](https://github.com/fleetdm/fleet/blob/main/docs/Contributing/reference/patterns-backend.md#unit-testing)
(updates to one hosts's records do not affect another)

- [x] QA'd all new/changed functionality manually

For unreleased bug fixes in a release candidate, one of:

- [x] Confirmed that the fix is not expected to adversely impact load
test results
- [x] Alerted the release DRI if additional load testing is needed

- [x] Checked table schema to confirm autoupdate
- [x] Checked schema for all modified table for columns that will
auto-update timestamps during migration.
- [x] Confirmed that updating the timestamps is acceptable, and will not
cause unwanted side effects.
- [x] Ensured the correct collation is explicitly set for character
columns (`COLLATE utf8mb4_unicode_ci`).
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.22%. Comparing base (699c711) to head (d36f189).
⚠️ Report is 2 commits behind head on rc-patch-fleet-v4.73.2.

Files with missing lines Patch % Lines
...s/20250816115553_OptimizeHostScriptResultsIndex.go 66.66% 1 Missing ⚠️
...17154557_AddKernelHostCountsIndexForVulnQueries.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           rc-patch-fleet-v4.73.2   #33378      +/-   ##
==========================================================
- Coverage                   63.22%   63.22%   -0.01%     
==========================================================
  Files                        1292     1292              
  Lines                      174390   174390              
==========================================================
- Hits                       110257   110251       -6     
- Misses                      54588    54592       +4     
- Partials                     9545     9547       +2     
Flag Coverage Δ
backend 63.22% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JordanMontgomery
Copy link
Copy Markdown
Member Author

Vuln test failures expected

@JordanMontgomery JordanMontgomery merged commit 5f62a50 into rc-patch-fleet-v4.73.2 Sep 23, 2025
34 of 37 checks passed
@JordanMontgomery JordanMontgomery deleted the JM-fix-4.73.2-migrations-in-4.73.2 branch September 23, 2025 19:55
@jmwatts jmwatts mentioned this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants