Improve alignment and logic around Arch linux os version displays#34420
Merged
Conversation
jacobshandling
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34420 +/- ##
==========================================
- Coverage 64.23% 64.23% -0.01%
==========================================
Files 2061 2061
Lines 207462 207455 -7
Branches 6935 7027 +92
==========================================
- Hits 133268 133262 -6
+ Misses 63744 63743 -1
Partials 10450 10450
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sgress454
approved these changes
Oct 17, 2025
Comment on lines
-265
to
+264
| {archLinuxPrefix} | ||
| <TooltipWrapperArchLinuxRolling /> | ||
| </> | ||
| ); | ||
| } | ||
| return <DataSet title="Operating system" value={value} />; | ||
| const version = summaryData.os_version; | ||
| const versionForRender = [ | ||
| "Arch Linux rolling", | ||
| "Arch Linux ARM rolling", | ||
| "Manjaro Linux rolling", | ||
| "Manjaro Linux ARM rolling", | ||
| ].includes(version) ? ( | ||
| // wrap a tooltip aroun the "rolling" suffix | ||
| <> | ||
| {version.slice(0, -8)} |
Contributor
There was a problem hiding this comment.
no need for the extra here?
Contributor
Author
There was a problem hiding this comment.
The style context in which these 2 elements are being rendered has some kind of spacing already, so this was making the gap excessive
jacobshandling
added a commit
that referenced
this pull request
Oct 17, 2025
…4420) **Related issue:** Resolves #34214 - Alignment in host summary fixed for both Firefox(L) and Chrome(R): <img width="1728" height="221" alt="Screenshot 2025-10-16 at 6 38 39 PM" src="https://github.com/user-attachments/assets/27d4489d-7a90-41bd-9b7d-53dfc95e4000" /> - Fix detection logic in Software > OS Versions table, render tooltip-wrapped "rolling" there when appropriate - [x] QA'd all new/changed functionality manually
jacobshandling
added a commit
that referenced
this pull request
Oct 17, 2025
sgress454
added a commit
that referenced
this pull request
Oct 21, 2025
mna
pushed a commit
that referenced
this pull request
Oct 27, 2025
…4420) **Related issue:** Resolves #34214 - Alignment in host summary fixed for both Firefox(L) and Chrome(R): <img width="1728" height="221" alt="Screenshot 2025-10-16 at 6 38 39 PM" src="https://github.com/user-attachments/assets/27d4489d-7a90-41bd-9b7d-53dfc95e4000" /> - Fix detection logic in Software > OS Versions table, render tooltip-wrapped "rolling" there when appropriate - [x] QA'd all new/changed functionality manually
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Resolves #34214
Fix detection logic in Software > OS Versions table, render tooltip-wrapped "rolling" there when appropriate
QA'd all new/changed functionality manually