fix(connectors): fix "Connection unknown." error happening for connectors get-config command

[laouji]

Fixes: PMNT-68

[coderabbitai]

Walkthrough

The changes adjust the control flow in the Run method of the PaymentsGetConfigController. Instead of explicitly checking for versions.V1, the method now uses a default case for handling payment versions not equal to versions.V0. This means that for any payment version aside from V0, the controller proceeds to list all connectors using the default behavior. No changes were made to the error handling or to the public entity declarations.

Changes

File	Summary
cmd/.../configs/getconfig.go	Modified the switch statement in the Run method by replacing the explicit versions.V1 case with a default case to list all connectors for non-V0 versions.

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant Controller as PaymentsGetConfigController
    participant Connector as Connector Service

    C->>Controller: Call Run() with PaymentVersion
    alt PaymentVersion is V0
       Controller->>Connector: Fetch configuration for V0
    else Other version
       Controller->>Connector: List all connectors (default case)
    end
    Connector-->>Controller: Return configuration data/error
    Controller-->>C: Return configuration data/error

Loading

Assessment against linked issues

Objective	Addressed	Explanation
PMNT-68: fctl get-config returns ERROR (PMNT-68)	✅

Poem

I'm a bunny with a hop so light,
Coding changes through day and night.
Removed a case, now default leads the way,
Connectors gather, come what may.
With a twitch of my nose, I celebrate the sight! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e5bb8a and abb6242.

⛔ Files ignored due to path filters (2)

• go.mod is excluded by !**/*.mod
• go.sum is excluded by !**/*.sum, !**/*.sum

📒 Files selected for processing (1)

• cmd/payments/connectors/configs/getconfig.go (1 hunks)

🔇 Additional comments (1)

cmd/payments/connectors/configs/getconfig.go (1)

97-97: Approved: Effective fix for the "Connection unknown." error

Changing from an explicit case for versions.V1 to a default case ensures that all payment versions other than V0 are handled properly. This would resolve the "Connection unknown." error that occurred when a version wasn't explicitly handled in the switch statement, causing the provider information not to be set in the store.

This approach is clean and future-proof as it ensures any new payment versions will follow the V1+ behavior by default.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.