Merged
Conversation
Previously the code was checking whether `issue_body` was falsy. The empty string is considered falsy, which would make this Action fail when the issue body was empty. Instead, explictly compare against `undefined` and tolerate issues with empty bodies. Fixes github#33
Contributor
Author
|
FYI, this is a blind fix. I'm not super familiar with Actions and don't even know how to manually test it. Happy to do that if you can give me advice on how. |
stephanmiehe
approved these changes
Mar 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the code was checking whether
issue_bodywas falsy.The empty string is considered falsy, which would make this Action
fail when the issue body was empty. Instead, explictly compare
against
undefinedand tolerate issues with empty bodies.Fixes #33