Skip to content

[BSv5] More utility updates#1361

Merged
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-more-utils-2023-01-23
Jan 24, 2023
Merged

[BSv5] More utility updates#1361
chalin merged 1 commit intogoogle:mainfrom
chalin:chalin-im-more-utils-2023-01-23

Conversation

@chalin
Copy link
Collaborator

@chalin chalin commented Jan 23, 2023

  • Contributes to Upgrade to Bootstrap 5.2 #470
  • Renamed .float-left and .float-right to .float-start and .float-end.
  • Renamed .ml-* and .mr-* to .ms-* and .me-* (remaining instances).
  • Renamed .pl-* and .pr-* to .ps-* and .pe-*.
  • Renamed .text-left and .text-right to .text-start and .text-end, except as noted below.

Preview: https://deploy-preview-1361--docsydocs.netlify.app/


Note: I've left out the following text-* change from the footer because the flex boxes aren't working for some reason, and so the first "developer" icon moves off of the page. I'll fix that separately.

diff --git a/layouts/partials/footer.html b/layouts/partials/footer.html
index 00485a5..a95bdad 100644
--- a/layouts/partials/footer.html
+++ b/layouts/partials/footer.html
@@ -4,14 +4,14 @@
     <div class="row">
       <div class="col-6 col-sm-4 text-xs-center order-sm-2">
         {{ with $links }}
-        {{ with index . "user"}}
+        {{ with index . "user" }}
         {{ template "footer-links-block"  . }}
         {{ end }}
         {{ end }}
       </div>
-      <div class="col-6 col-sm-4 text-right text-xs-center order-sm-3">
+      <div class="col-6 col-sm-4 text-end text-xs-center order-sm-3">
         {{ with $links }}
-        {{ with index . "developer"}}
+        {{ with index . "developer" }}
         {{ template "footer-links-block"  . }}
         {{ end }}
         {{ end }}

@chalin chalin mentioned this pull request Jan 23, 2023
50 tasks
@chalin chalin merged commit 4bd3581 into google:main Jan 24, 2023
@chalin chalin deleted the chalin-im-more-utils-2023-01-23 branch January 24, 2023 15:08
@chalin
Copy link
Collaborator Author

chalin commented Jan 24, 2023

Note: I've left out the following text-* change from the footer because the flex boxes aren't working for some reason, and so the first "developer" icon moves off of the page. I'll fix that separately.

This will be tracked via:

dseynaev pushed a commit to openanalytics/docsy that referenced this pull request Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant