Skip to content

go.sum: clear unused entries, and tabpane cleanup#1386

Merged
chalin merged 1 commit intogoogle:mainfrom
deining:go.sum
Feb 2, 2023
Merged

go.sum: clear unused entries, and tabpane cleanup#1386
chalin merged 1 commit intogoogle:mainfrom
deining:go.sum

Conversation

@deining
Copy link
Contributor

@deining deining commented Feb 1, 2023

@deining - is the content of this file meant to be (generally) cumulative?
Eg., why are there still entries for older versions of the Docsy dependencies and BS v4?

Originally posted by @chalin in #1374 (comment)

The entries for older versions of the Docsy dependencies and BS v4 can be safely removed. That's what this PR is about.
The PR also performs minor code cleanup within the shortcode 'tabpane'.

shortcode 'tabpane': minor code cleanup
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in the thread of the comment I made, go mod tidy doesn't affect the dependencies go.sum for me, but I'm willing to go with your suggestion.

@chalin chalin changed the title go.sum: clear unused entries go.sum: clear unused entries, and tabpane cleanup Feb 2, 2023
@chalin chalin merged commit a780b0d into google:main Feb 2, 2023
@deining deining deleted the go.sum branch February 2, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants