Blog list layout: no need for row/col-12 grid styling of content#1572
Merged
chalin merged 1 commit intogoogle:mainfrom Jun 16, 2023
Merged
Conversation
Contributor
|
As seen in the preview, the spacing above the |
Collaborator
Author
|
Thanks for noticing that. I had only looked at the build of the example site -- it is strange that the page-meta spacing would be fixed there. I've stuck out that item from the opening comment -- it wasn't the original issue targeted by this PR. I can track the page-meta issue separately: Any other comments @deining? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bit hard to see, but there are no content changes in the layout other than:
<div class="row"><div class="col-12">{{ if .Pages -}}...</div></div>by<div class="td-blog-posts">{{ if .Pages -}}...</div>divs for the pagination<h2>to<div class="h2">of the post-list headerNote that the class names
td-blog-posts*currently have not styles associated with them.In the before and after images, note the following fixes:
Spacing above the View page source page-meta buttonsBefore
After
Showing the pagination buttons: