css: Support dartsass as transpiler#1598
Merged
chalin merged 1 commit intogoogle:mainfrom Jul 27, 2023
Merged
Conversation
chalin
reviewed
Jul 5, 2023
Collaborator
chalin
left a comment
chalin
left a comment
There was a problem hiding this comment.
Thanks for catching this.
I thought that Hugo used Dart Sass now, given that libsass is deprecated.
Collaborator
|
I'm not sure why the build is failing after a rebase. |
Contributor
Author
After another rebase, the checker is green again 😄 |
chalin
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When trying to run docsy theme with dart sass as transpiler, the build currently fails:
This is due to the fact that - contrary to libsass - dart sass does not support multi-line strings.
This PR fixes this issue.