Skip to content

Feedback questions: add localization#1615

Merged
chalin merged 1 commit intogoogle:mainfrom
deining:page-helpful-i18n
Jul 27, 2023
Merged

Feedback questions: add localization#1615
chalin merged 1 commit intogoogle:mainfrom
deining:page-helpful-i18n

Conversation

@deining
Copy link
Contributor

@deining deining commented Jul 7, 2023

This PR adds localization to docsy's feedback feature.


/cc @tobiaskohlbau

@deining deining force-pushed the page-helpful-i18n branch from ee3aa24 to 680b007 Compare July 7, 2023 20:38
@deining deining force-pushed the page-helpful-i18n branch from 680b007 to 001173b Compare July 22, 2023 08:06
@chalin chalin force-pushed the page-helpful-i18n branch from 001173b to 13f1bb3 Compare July 27, 2023 18:06
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks. See inline comments.

@chalin chalin requested a review from LisaFC July 27, 2023 18:22
@deining deining force-pushed the page-helpful-i18n branch from 13f1bb3 to d5dcd47 Compare July 27, 2023 19:53
@deining deining requested a review from chalin July 27, 2023 19:56
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ✨

@chalin chalin merged commit ab1f1d0 into google:main Jul 27, 2023
@deining deining deleted the page-helpful-i18n branch November 13, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

i18n of page feedback

2 participants