Fix links for single language sites

[LisaFC]

• Fixes Broken logic for building GitHub URL for "Edit this page" link #138
• Fixes page meta links should respect .Site.IsMultiLingual #981
• Fixes Github View/Edit links broken if defaultContentLanguageInSubdir = false #1420

Requires Hugo 0.112.0+

[LisaFC]

See discussion with @lyind in #1486

[chalin]

This breaks the page-meta links for some pages on the OTel website, for example the mission page. I'll investigate further as soon as I can.

[chalin]

@LisaFC et al. - do you have a reference to a public site that exhibits the broken page-meta links? Or do you have a simple test case to reproduce the problem?

[chalin]

Ah, nm, found one :)

[chalin]

The line your are changing was added in support of builds under Windows:

• Add fix for Windows formatted path values #163

Removing the line will introduce a regression IMHO.

[chalin]

Actually, our tests are passing under windows, so I'll assume that this is still ok. If not, we can address the regression later.

[LisaFC]

Ok, let me take a further look

[LisaFC]

If you remove the overridden partial in this project you should see the problem: https://github.com/LisaFC/monolang

[chalin]

I got the monolang repo working with Docsy at HEAD (using simple front matter) but, regardless, I'm feeling that your fix is the right way to go! 🎉 I have a tweaked version locally, and will share it + more feedback when I'm back.

[chalin]

Great work! This definitely seems like the right way to fix this. There is some cleanup in the code that I'd like to do, but I'll address that in a followup PR, and add a statement about this being a breaking change to the CHANGELOG.

[chalin]

Actually, our tests are passing under windows, so I'll assume that this is still ok. If not, we can address the regression later.