NPM dependencies: Update font-awesome package to include new twitter logo#1754
NPM dependencies: Update font-awesome package to include new twitter logo#1754chalin merged 3 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
21cdfc4 to
4b9c05d
Compare
deining
left a comment
There was a problem hiding this comment.
Thanks for your PR!
This PR takes care of the npm dependency. We have font-awesome as module dependency too, which also needs to be updated.
@venkyvajrala: can you add this missing part to the PR as well, please?
|
@deining Updated module dependency for font-awesome library. |
4aca01d to
9fdcbdc
Compare
9fdcbdc to
183df8f
Compare
chalin
left a comment
There was a problem hiding this comment.
LGTM, thanks 👍🏻
FYI: In the past we've had patch updates to FA that affecting spacing, which is why I preferred waiting for 0.8.0 to be released first.
Fixes: #1753