Skip to content

Conversation

@chalin
Copy link
Collaborator

@chalin chalin commented Feb 28, 2024

@fekete-robert
Copy link
Contributor

I think we could update userguide/hugo.yaml as well (

googleAnalytics:
) to use the new notation

@chalin
Copy link
Collaborator Author

chalin commented Mar 4, 2024

I think we could update userguide/hugo.yaml as well (

googleAnalytics:

) to use the new notation

@fekete-robert - the UG config is already using the new services field:

services:
googleAnalytics:
# id: G-XXXXXXXXX # Waiting on https://github.com/google/docsy/issues/1097

The old parameter, also named GoogleAnalytics, was at the top level.

@chalin
Copy link
Collaborator Author

chalin commented Mar 4, 2024

Oh, I see that I can remove the comment, and the entire UG config entry for that matter! Thanks @fekete-robert bringing that entry to my attention.

@chalin
Copy link
Collaborator Author

chalin commented Mar 4, 2024

Thanks for the review @LisaFC. Merging. I can address any followup comments in a subsequent PR.

@chalin chalin merged commit ff2a42e into google:main Mar 4, 2024
@chalin chalin deleted the chalin-im-ga-id-2024-02-28 branch March 4, 2024 20:10
@chalin chalin added this to the 24Q1 milestone Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Site param .Site.GoogleAnalytics was deprecated in Hugo 0.120.0

3 participants