Skip to content

Fix command tree grouping by frame.#1950

Merged
pmuetschard merged 1 commit into
google:masterfrom
pmuetschard:frame_fix
Jun 4, 2018
Merged

Fix command tree grouping by frame.#1950
pmuetschard merged 1 commit into
google:masterfrom
pmuetschard:frame_fix

Conversation

@pmuetschard

Copy link
Copy Markdown
Member

Fixes a bug introduced by commit 62fa80a, where the "last in frame" events inferred from "start of frame" commands where added after the "start of frame" event instead of before it, essentially ending frames on the same command as starting them.

@pmuetschard pmuetschard requested a review from ben-clayton June 1, 2018 19:51
@pmuetschard

Copy link
Copy Markdown
Member Author

+CC @iburinoc

Fixes a bug introduced by commit 62fa80a, where the "last in
frame" events inferred from "start of frame" commands where added
after the "start of frame" event instead of before it, essentially
ending frames on the same command as starting them.
@sean-purcell

Copy link
Copy Markdown
Contributor

Good catch, LGTM

@pmuetschard pmuetschard merged commit 3656095 into google:master Jun 4, 2018
@pmuetschard pmuetschard deleted the frame_fix branch June 4, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants