Skip to content

Vulkan: Fix crash at VkDestroyDebugReportCallbackEXT#1998

Merged
qining merged 1 commit into
google:masterfrom
qining:hang-at-destroy-callback-handle
Jun 20, 2018
Merged

Vulkan: Fix crash at VkDestroyDebugReportCallbackEXT#1998
qining merged 1 commit into
google:masterfrom
qining:hang-at-destroy-callback-handle

Conversation

@qining

@qining qining commented Jun 18, 2018

Copy link
Copy Markdown
Contributor

If the application uses debug report callback, we should not use our
synthetic commands to process their callback handles.

If the application uses debug report callback, we should not use our
synthetic commands to process their callback handles.
@qining qining requested a review from AWoloszyn June 18, 2018 21:21
@qining

qining commented Jun 18, 2018

Copy link
Copy Markdown
Contributor Author

@iburinoc PTAL. Hopfully this should fix the hang issue.

@sean-purcell

Copy link
Copy Markdown
Contributor

Confirmed that this fixes the hang, thanks!

@qining qining merged commit e5b2d6b into google:master Jun 20, 2018
@qining qining deleted the hang-at-destroy-callback-handle branch October 23, 2018 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants