Vulkan: Fix infinite loop in state_rebuilder.#2391
Merged
Conversation
AWoloszyn
approved these changes
Nov 23, 2018
AWoloszyn
left a comment
AWoloszyn
left a comment
Contributor
There was a problem hiding this comment.
"forms a loop or" << That is a bit scary, and we should probably warn the user about that. But that is a separate problem.
The problematic case is a state containing multiple pipelines, some of which have 0 basePipeline, and some of which have a basePipeline that forms a loop or doesn't exist. This caused both `numHandled` and `len(unhandledPipelines)` to be non-zero forever. This change resets `numHandled` for each pass over `unhandledPipelines`. Fixes google#2390
bjoeris
force-pushed
the
pr-getPipelinesInOrder-inf-loop
branch
from
75dc07b to
363e5a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problematic case is a state containing multiple pipelines, some of which
have 0 basePipeline, and some of which have a basePipeline that forms a loop or
doesn't exist. This caused both
numHandledandlen(unhandledPipelines)to benon-zero forever. This change resets
numHandledfor each pass overunhandledPipelines.Fixes #2390