Don't mark deleted git entries as invalid.#829
Merged
Merged
Conversation
Contributor
|
Could you please add a bit more of the "why" to the description? |
Collaborator
Author
done. |
Contributor
Is it correct that this behaviour is not currently implemented? |
Collaborator
Author
This is already implemented per osv.dev/docker/worker/worker.py Line 509 in ca38cad |
andrewpollock
approved these changes
Nov 16, 2022
This was referenced Apr 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The supported way to handle making entries as invalid is to mark them as "withdrawn" and
leave the entry intact.
This also guards against availability issues from source feeds, such as when a bug in their
system causes their entries to be deleted (e.g. github/advisory-database@06071dd)