This repository was archived by the owner on Sep 27, 2023. It is now read-only.
remove usage of deprecated methods in guava#61
Merged
yihanzhen merged 2 commits intoAug 1, 2018
Conversation
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
============================================
- Coverage 61.34% 60.19% -1.15%
+ Complexity 141 138 -3
============================================
Files 14 14
Lines 608 603 -5
Branches 92 92
============================================
- Hits 373 363 -10
- Misses 212 217 +5
Partials 23 23
Continue to review full report at Codecov.
|
garrettjonesgoogle
approved these changes
Aug 1, 2018
Contributor
garrettjonesgoogle
left a comment
garrettjonesgoogle
left a comment
There was a problem hiding this comment.
LGTM after the tests pass
Contributor
garrettjonesgoogle
left a comment
garrettjonesgoogle
left a comment
There was a problem hiding this comment.
Actually, some more stuff to do...
| exceptionType, | ||
| new GaxFunctionToGuavaFunction<X, V>(callback)); | ||
| new GaxFunctionToGuavaFunction<X, V>(callback), | ||
| directExecutor()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return new ListenableFutureToApiFuture<>( | ||
| Futures.transform( | ||
| listenableFutureForApiFuture(input), new GaxFunctionToGuavaFunction<V, X>(function))); | ||
| return transform(input, function, directExecutor()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| } | ||
| }); | ||
| return new ListenableFutureToApiFuture<>(listenableOutput); | ||
| return transformAsync(input, function, directExecutor()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Please enter the commit message for your changes. Lines starting
Contributor
Author
|
PTAL @garrettjonesgoogle |
miraleung
pushed a commit
that referenced
this pull request
Jun 4, 2020
* remove usage of deprecated methods in guava * Deprecated methods parellel to those deparecated in guava
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.