Fix PathTemplate matcher to match path with protocol and hostname#68
Conversation
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
============================================
+ Coverage 60.19% 60.38% +0.19%
- Complexity 138 143 +5
============================================
Files 14 14
Lines 603 616 +13
Branches 92 94 +2
============================================
+ Hits 363 372 +9
- Misses 217 219 +2
- Partials 23 25 +2
Continue to review full report at Codecov.
|
|
Thanks for filing this PR! Does this PR address anything else other than googleapis/google-cloud-java#3604? Regarding googleapis/google-cloud-java#3604, can you write a test that parses (With regard to that issue, our plan is to strip off the |
|
@andreamlin Thanks for review. Added test case for googleapis/google-cloud-java#3604. This PR was suppose to fix googleapis/google-cloud-java#3604 as well as in general to support the url with protocol and hostname. This is non breaking change would also work with your other solution. |
|
@andreamlin can you please review? |
* Fix PathTemplate matcher to match path with protocol and hostname
Fixes #3604 Fix matcher to match path with protocol and hostname