Skip to content

Pass library and Python version in x-goog-api-client#734

Merged
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:http-headers
Aug 9, 2019
Merged

Pass library and Python version in x-goog-api-client#734
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:http-headers

Conversation

@busunkim96
Copy link
Copy Markdown
Contributor

Closes #729

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 5, 2019
@busunkim96 busunkim96 requested a review from dazuma August 5, 2019 20:16
Comment thread googleapiclient/model.py Outdated
Comment thread tests/test_json_model.py Outdated
Comment thread tests/test_http.py Outdated
@busunkim96 busunkim96 requested a review from a team August 5, 2019 23:49
Comment thread tests/test_json_model.py
Comment thread googleapiclient/model.py
Comment thread tests/test_json_model.py
@asiunov
Copy link
Copy Markdown

asiunov commented Aug 13, 2019

@busunkim96 @tseaver @dazuma
seems like this PR introduces some regression. I started to get a signature mismatch when use this sdk (on .get_media method):

W0813 19:40:45.663586 1 http.py:118] Invalid JSON content from response: b"<?xml version='1.0' encoding='UTF-8'?><Error><Code>SignatureDoesNotMatch</Code><Message>The request signature we calculated does not match the signature you provided. Check your Google secret key and signing method.</Message><StringToSign>GET\n\n\n1565725545\nx-goog-api-client:gdcl/1.7.11 gl-python/3.7.4\n/...</StringToSign></Error>"

@busunkim96
Copy link
Copy Markdown
Contributor Author

@asiunov Thank you for the report! Could you let us know which API you are using? (A small sample would also be much appreciated).

I see a similar error mentioned for node, but am unsure if this is the same cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ensure client is reporting Python version

7 participants