chore: new bidi appendable channel bootstrappable#3226
Closed
BenWhitehead wants to merge 1 commit intononblocking-appendable/09/nonblocking-bufferingfrom
Closed
chore: new bidi appendable channel bootstrappable#3226BenWhitehead wants to merge 1 commit intononblocking-appendable/09/nonblocking-bufferingfrom
BenWhitehead wants to merge 1 commit intononblocking-appendable/09/nonblocking-bufferingfrom
Conversation
Collaborator
BenWhitehead
commented
Aug 5, 2025
BenWhitehead
commented
- Add FlushPolicy.MinFlushSizeFlushPolicy.maxPendingBytes
- Add new contructor to ChannelSession to allow the resultFuture to be passed in.
- Create temporary BlobAppendableUploadImpl.AppendableUnbufferedWritableByteChannel to allow both old and new implementations to be passed to BlobAppendableUploadImpl -- this interface will be removed in cleanup
- Add new implementation using streaming buffer management as a sibling to the existing implementation. The existing implementation will be removed entirely in cleanup.
- Refactored tests to follow
product-auto-label
bot
added
size: l
BenWhitehead
force-pushed
the
nonblocking-appendable/09/nonblocking-buffering
branch
from
555ee59 to
cbee997
Compare
BenWhitehead
force-pushed
the
nonblocking-appendable/10/channel-bootable
branch
from
c0febee to
bff6b91
Compare
BenWhitehead
force-pushed
the
nonblocking-appendable/09/nonblocking-buffering
branch
from
cbee997 to
e3938f0
Compare
BenWhitehead
force-pushed
the
nonblocking-appendable/10/channel-bootable
branch
from
bff6b91 to
287df3a
Compare
BenWhitehead
force-pushed
the
nonblocking-appendable/09/nonblocking-buffering
branch
from
e3938f0 to
0df938f
Compare
BenWhitehead
force-pushed
the
nonblocking-appendable/10/channel-bootable
branch
from
287df3a to
bff9131
Compare
BenWhitehead
force-pushed
the
nonblocking-appendable/09/nonblocking-buffering
branch
from
0df938f to
f262a2c
Compare
* Add FlushPolicy.MinFlushSizeFlushPolicy.maxPendingBytes * Add new contructor to ChannelSession to allow the resultFuture to be passed in. * Create temporary BlobAppendableUploadImpl.AppendableUnbufferedWritableByteChannel to allow both old and new implementations to be passed to BlobAppendableUploadImpl -- this interface will be removed in cleanup * Add new implementation using streaming buffer management as a sibling to the existing implementation. The existing implementation will be removed entirely in cleanup. * Refactored tests to follow
BenWhitehead
force-pushed
the
nonblocking-appendable/10/channel-bootable
branch
from
bff9131 to
fb34cb2
Compare
BrandonY
approved these changes
Aug 11, 2025
BrandonY
left a comment
BrandonY
left a comment
There was a problem hiding this comment.
Got a little lost on this one, but the general idea seems reasonable
| ? storage.getBidiWriteObjectRequestForTakeover(info, opts) | ||
| : storage.getBidiWriteObjectRequest(info, opts); | ||
| if (newImpl) { | ||
| // TODO: make configurable |
There was a problem hiding this comment.
Are there style rules for TODOs? Do they need bug numbers or names or something? Actually, is there a style guide in general I should be checking?
BenWhitehead
added a commit
that referenced
this pull request
Aug 20, 2025
## Description feat: *breaking behavior* rewrite Storage.blobAppendableUpload to be non-blocking and have improved throughput (#3231) Rewrite internals of BlobAppendableUpload to provide non-blocking write calls, and it take advantage of grpc async message handling. When `AppendableUploadWriteableByteChannel#write(ByteBuffer)` is called, an attempt will be made to enqueue the bytes in the outbound queue to GCS. If there is only enough room to partially consume the bytes provided in the `ByteBuffer` the write call will return early specifying the number of bytes actually consumed. As acknowledgements come in from gcs, enqueued messages will be evicted freeing space in the outbound queue. Thereby allowing more bytes to be consumed and enqueued. Given appendable objects are still in private preview I can't quote any metrics here, however preliminary benchmarking of several million objects across a range of sizes show across the board throughput improvments. Because the channel's write call is now non-blocking, if you want to block your application until the full buffer is consumed some new helper methods have been added in StorageChannelUtils to provide blocking behavior. A new method `MinFlushSizeFlushPolicy#withMaxPendingBytes(long)` has been added to allow limiting the number of pending outbound bytes. The default values is 16MiB, but can be configured lower if necessary. ## Release Notes BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT feat: *breaking behavior* rewrite Storage.blobAppendableUpload to be non-blocking and have improved throughput (#3231) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add StorageChannelUtils to provide helper methods to perform blocking read/write to/from non-blocking channels (#3231) END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: add MinFlushSizeFlushPolicy#withMaxPendingBytes(long) (#3231) END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix: update BlobAppendableUploadConfig and FlushPolicy.MinFlushSizeFlushPolicy to default to 4MiB minFlushSize and 16MiB maxPendingBytes (#3249) END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix: make FlushPolicy${Min,Max}FlushSizeFlushPolicy constructors private (#3217) END_NESTED_COMMIT END_COMMIMT_OVERRIDE ## Sub PRs This PR is made of up the following PRs, in sequence 1. #3217 2. #3218 3. #3219 4. #3220 5. #3221 6. #3222 7. #3223 8. #3224 9. #3225 10. #3226 11. #3227 12. #3228 13. #3229 14. #3230 15. #3235 16. #3236 17. #3241 18. #3242 19. #3246 20. #3248 21. #3249 22. #3252
Collaborator
Author
|
Merged in #3231 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
