Skip to content

Conversation

@l1nd3r0th
Copy link
Contributor

@l1nd3r0th l1nd3r0th commented Jun 26, 2025

Summary

Dear Hynek,

Thanks for building and maintaining structlog!

I'm using a pytest fixture to capture logs in an application test suite. In some test cases it's convenient to be able to inspect context variables.

This PR, if accepted, enables capture_logs() to capture logs with context variables like this:

@pytest.fixture(name="log_output")
def fixture_log_output() -> Iterator[LogMatcher]:
    with capture_logs(
        processors=[
            structlog.contextvars.merge_contextvars,
        ]
    ) as logs:
        yield LogMatcher(captured_logs=logs)

Or whatever other interesting processing people might like to do. :)

I realize I probably could have gotten the same result by configuring processors in a fixture, as shown in the docs, something like:

@pytest.fixture(name="log_output")
def fixture_log_output():
    return LogCapture()

@pytest.fixture(autouse=True)
def fixture_configure_structlog(log_output):
    structlog.configure(
        processors=[structlog.contextvars.merge_contextvars, log_output]
    )

...but I like how capture_logs() restores the configuration after itself.

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    • The CI fails with less than 100% coverage.
  • New APIs are added to our typing tests in api.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      • The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks – I've completely forgotten about capture_logs. :)

Sorry for the long delay, it's been busy. :|

@hynek hynek merged commit 70ca975 into hynek:main Jul 23, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants