Skip to content

Conversation

@agunnerson-elastic
Copy link
Contributor

Summary

Previously, the conditional always checked specifically for timestamp, which caused MaybeTimeStamper to always behave like TimeStamper when a custom key is used.

Pull Request Check List

  • Do not open pull requests from your main branch – use a separate branch!
    • There's a ton of footguns waiting if you don't heed this warning. You can still go back to your project, create a branch from your main branch, push it, and open the pull request from the new branch.
    • This is not a pre-requisite for your pull request to be accepted, but you have been warned.
  • Added tests for changed code.
    • The CI fails with less than 100% coverage.
  • New APIs are added to our typing tests in api.py.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives.
      • The next version is the second number in the current release + 1. The first number represents the current year. So if the current version on PyPI is 23.1.0, the next version is gonna be 23.2.0. If the next version is the first in the new year, it'll be 24.1.0.
  • Documentation in .rst and .md files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.
  • Consider granting push permissions to the PR branch, so maintainers can fix minor issues themselves without pestering you.

Previously, the conditional always checked specifically for `timestamp`,
which caused MaybeTimeStamper to always behave like TimeStamper when a
custom key is used.

Signed-off-by: Andrew Gunnerson <[email protected]>
Copy link
Owner

@hynek hynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thanks!

@hynek hynek merged commit c44431c into hynek:main Sep 11, 2025
20 checks passed
@agunnerson-elastic agunnerson-elastic deleted the maybe-timestamper-custom-key branch September 11, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants