Skip to content

fix: allow maven to publish without implicit task ordering#3693

Merged
iBotPeaches merged 1 commit into
masterfrom
maven-fix
Sep 17, 2024
Merged

fix: allow maven to publish without implicit task ordering#3693
iBotPeaches merged 1 commit into
masterfrom
maven-fix

Conversation

@iBotPeaches
Copy link
Copy Markdown
Owner

This fixes 2 things.

A problem was found with the configuration of task ':brut.apktool:apktool-cli:shadowJar' (type 'Jar').
  - Gradle detected a problem with the following location: 'Apktool/brut.apktool/apktool-cli/build/libs/apktool-cli.jar'.
    
    Reason: Task ':brut.apktool:apktool-cli:generateMetadataFileForMavenJavaPublication' uses this output of task ':brut.apktool:apktool-cli:shadowJar' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed.
Execution failed for task ':brut.apktool:apktool-cli:generateMetadataFileForMavenJavaPublication'.
> java.io.FileNotFoundException: Apktool/brut.apktool/apktool-cli/build/libs/apktool-cli-javadoc.jar (No such file or directory)

  • Adapted with some ugly verbose config to depend Maven tasks on the completion of shadowJar
  • Ensured the clean build directory doesn't purge sources/javadoc (which is only apparent on maven publish)

@iBotPeaches iBotPeaches added this to the v2.10.0 milestone Sep 17, 2024
@iBotPeaches iBotPeaches merged commit 6d1017e into master Sep 17, 2024
@iBotPeaches iBotPeaches deleted the maven-fix branch September 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant