fix: use item tags for incompatible formats#4097
Merged
Merged
Conversation
iBotPeaches
approved these changes
Feb 26, 2026
iBotPeaches
added a commit
to iBotPeaches/apktool.org
that referenced
this pull request
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves validation of value format compatibility with a resource type, and output
<item>tag if the value format is incompatible (e.g. a string value for adrawable, etc).As I replied in #4096, aapt2 will reject values that are not a file or a reference for certain types (like
layout) even if we output them as<item>tags with theformatattribute. Such values are non-standard (custom post-processing most likely) and can only be patched by changing aapt2 behavior, which is out of the scope of this PR.