fix(refresher): close animation and hidden on pull down - Fixes #16254#16700
Merged
Conversation
paulstelzer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several bugs in refresher in Ionic v4 like mentioned in #16254
[x] FIXED: The refresher itself lies above the content, instead of below. This means that the instant you start to pull, it is completely visible above your content, instead of sliding out from underneath it.
[x] FIXED: After completing the refresher action, the content jumps back instantly, instead of sliding back up.
[x] Was already fixed: There is a console.log('start') still in compiled @ionic/core code which triggers when starting to you start to drag on a page with the refresher.
BEFORE
AFTER
It has now the same optical look like in v3 and is working in Chrome and Firefox. This is how it looks in Firefox:
Ionic Version:
Fixes: #16254